Peter Hessler wrote (2023-08-29 08:31 CEST):
> On 2023 Aug 29 (Tue) at 08:22:20 +0200 (+0200), Stefan Hagen wrote:
> :Peter Hessler wrote (2023-08-29 08:08 CEST):
> :> I just noticed that the distfiles for these fonts isn't versioned, which
> :> is creating problems for the bulk build systems.
> :>
> :> Here's a simple patch that'll create ugly versioned filenames. (I
> :> wasn't able to easily trick it into FONT-VER-SUFFIX order.)
> :>
> :> OK?
> :
> :Is there a benefit versioning the files instead of DIST_SUBDIR?
> :
>
> Yes, when you update the fonts then the distfile has a unique filename,
> so it won't conflict with an older version of the font.
>
> In my mind, DIST_SUBDIR is more for organization, rather than
> versioning.
DIST_SUBDIR=nerd-fonts-${VERSION} has the same effect, doesn't it?
An older/newer version would never end up in the same directory.
I see it used that way a couple of times:
/usr/ports/fonts/ibm-plex/Makefile:DIST_SUBDIR = ibm-plex-$V
/usr/ports/fonts/inconsolata-new/Makefile:DIST_SUBDIR = inconsolata-$V
/usr/ports/fonts/literata/Makefile:DIST_SUBDIR = literata-$V
/usr/ports/fonts/noto/cjk/Makefile:DIST_SUBDIR = noto-cjk-$V
/usr/ports/fonts/pkfonts/Makefile:DIST_SUBDIR= pkfonts-${VERSION}
/usr/ports/fonts/roboto-fonts/Makefile:DIST_SUBDIR = roboto-$V
/usr/ports/fonts/intel-one-mono/Makefile:DIST_SUBDIR = intel-one-mono-$V
For me, both solutions are fine. Please go ahead and commit yours.
> :Either way, OK sdk@
> :
>
> --
> Why isn't there a special name for the tops of your feet?
> -- Lily Tomlin
>
