On 9/3/2023 4:29 AM, Stefan Hagen wrote: > Lucas Raab wrote (2023-09-02 18:16 IST): >> On Sat, Sep 02, 2023 at 05:06:31PM +0000, Lucas Raab wrote: >>> On Sat, Sep 02, 2023 at 03:42:22PM +0000, Lucas Raab wrote: >>>> On Sat, Sep 02, 2023 at 12:35:01PM +0000, Lucas Raab wrote: >>>>> Hello, >>>>> >>>>> With the recent additions of libmpq, sdl2-audiolib, simpleini, and >>>>> libsmackerdec, this devilutionx update should work. I've only tested on >>>>> amd64 >>>>> and only with single player. >>>>> >>>>> Using plain `devilutionx` will crash attempting to play the intro video, >>>>> but >>>>> for now, that can be skipped with `devilutionx -n`. Other tests and >>>>> feedback? >>>>> >>>>> Much thanks to bcallah@ for getting the diff to this point! >>>>> >>>>> Thanks, >>>>> Lucas >>>> >>>> 1.5.1 was released just yesterday so here's an updated diff taking that >>>> into >>>> account along with sthen's feedback >>>> >>>> (also cc MAINTAINER since I forgot to last time :/) >>> >>> Updated diff after feedback from sdk@ and thfr@ >> >> And one last update with feedback from tb@, thanks! > > I have a few more things: > > Changes: > * -DBINARY_RELEASE=ON is not checked anymore.It's now called > -DCMAKE_BUILD_TYPE=Release > * Added -DDEVILUTIONX_SYSTEM_LIBSODIUM=ON > * Added a patch to disable sound in movie sequences (avoids startup > crash without -n) > * Added a sentence about the movie sound to README > > I tried fixing the crash/sound in movies, but couldn't. So I disabled > it. >
OK for this version. I'll look into the movie audio next update. ~Brian
