On Fri, Sep 08 2023, Johannes Thyssen Tishman wrote:

Some comments on the port:

- I think it would be better to use a variable for the version to use in PKGNAME and GH_TAGNAME for easier updates

- I'm not 100% sure but I believe HOMEPAGE is set already when using
GH_*. However instead of using the GitHub page, we could use the
official website: https://www.prusa3d.com/page/prusaslicer_424/

On another note, are you by any chance working on the latest release (2.6.1)? I was actually working on it before you submitted this one
(in jasperla/openbsd-wip) and I was having a hard time
compiling. Since your submission I've been trying to use your port as
a base but it doesn't seem like a trivial update. There's a new
dependency (NanoSVG) which is only header files and can be included trivially but I'm still getting other compilation errors (something with TBB::tbbmalloc). The FreeBSD port has been very helpful, but still no success. I'd love to help if you are already on it, so let me
know.

I've tried it as well, but I got stuck at the same point :(

Let's sync up on that later, so we can work together on fixing 2.6 build.

I'm attaching a new version of the port addressing your comments and adding myself as maintainer. Diff bellow:


diff --git a/cad/prusa-slicer/Makefile b/cad/prusa-slicer/Makefile
index 8c98918..d331265 100644
--- a/cad/prusa-slicer/Makefile
+++ b/cad/prusa-slicer/Makefile
@@ -1,14 +1,17 @@
COMMENT =      g-code generator for 3D printers

-PKGNAME =      prusa-slicer-2.5.2
+V =            2.5.2
+PKGNAME =      prusa-slicer-${V}

GH_ACCOUNT =   prusa3d
GH_PROJECT =   PrusaSlicer
-GH_TAGNAME =   version_2.5.2
+GH_TAGNAME =   version_${V}

CATEGORIES =   cad

-HOMEPAGE =     https://github.com/prusa3d/PrusaSlicer
+HOMEPAGE =     https://www.prusa3d.com/prusaslicer/
+
+MAINTAINER =   Renato Aguiar <ren...@renatoaguiar.net>

# AGPLv3+
PERMIT_PACKAGE =       Yes


Attachment: prusa-slicer.tar.gz
Description: Binary data


--
Renato Aguiar

Reply via email to