On 09/16 09:56, Theo Buehler wrote: > On Thu, Sep 14, 2023 at 06:06:37PM +0000, Jeremy Evans wrote: > > PostgreSQL 16.0 was released today: > > https://www.postgresql.org/about/news/postgresql-16-released-2715/ > > > > As usual, we don't plan to change the default version in ports until > > 16.1, and after we have prepared updates all software that depends on > > PostgreSQL to support the new version. However, for early testing, > > here's a diff to test with. > > As mentioned elsewhwere, the diff needs an installed icu4c to configure > as it is now. I ran a bulk with '--without-icu' added to CONFIGURE_ARGS.
Thanks! I've updated my copy to use --without-icu. If someone wants ICU support in PostgreSQL, please speak up and describe why. > There are a few version checks that break some ports, as usual. > There is at least one .so in the server that had changes amounting to a > major bump, but for some reasone they aren't versioned. Should they be? I believe the @so entries in PLIST-server are only designed for use by PostgreSQL itself via dlopen. I don't think external code should be linking to them, and therefore there is no reason to version them. > databases/citus version > databases/pg_sqlite_fdw version > databases/postgresql-odbc ? > databases/postgresql-pllua version > databases/timescaledb version > geo/pgpointcloud API break in -server For these, it's best to wait a couple months till upstream has had a chance to update. After 16.1 is released, I'll take a look at these and see if upstream has released a new version compatible with PostgreSQL 16, or has at least committed fixes that can be backported. Thanks, Jeremy > > Not sure what's up with postgresql-odbc, maybe missing stdarg/stdbool > includes? > > > databases/citus: > configure: error: Citus is not compatible with the detected PostgreSQL > version 16. > > databases/pg_sqlite_fdw: > Makefile:40: *** PostgreSQL 11, 12, 13, 14 or 15 is required to compile this > extension. Stop. > > databases/postgresql-pllua: > ===> postgresql-pllua-2.0.10p0 depends on: postgresql-server->=15,<16 - > default postgresql-server-16.0 does not match > > databases/timescaledb: > CMake Error at CMakeLists.txt:349 (message): > TimescaleDB only supports PostgreSQL 12, 13, 14 and 15 > > databases/postgresql-odbc: > > cc -DHAVE_CONFIG_H -I. -I/usr/local/include -I/usr/local/include/postgresql > -I/usr/local/include/postgresql/internal -DUNICODE_SUPPORT -O2 -pipe -MT > psqlodbcw_la-info.lo -MD -MP -MF .deps/psqlodbcw_la-info.Tpo -c info.c -fPIC > -DPIC -o .libs/psqlodbcw_la-info.o > In file included from info.c:34: > In file included from ./connection.h:14: > /usr/local/include/postgresql/internal/pqexpbuffer.h:168:8: error: unknown > type name 'bool' > extern bool appendPQExpBufferVA(PQExpBuffer str, const char *fmt, va_list > args) pg_attribute_printf(2, 0); > ^ > /usr/local/include/postgresql/internal/pqexpbuffer.h:168:67: error: unknown > type name 'va_list'; did you mean '__va_list'? > extern bool appendPQExpBufferVA(PQExpBuffer str, const char *fmt, va_list > args) pg_attribute_printf(2, 0); > ^~~~~~~ > __va_list > /usr/include/machine/_types.h:126:27: note: '__va_list' declared here > typedef __builtin_va_list __va_list; > ^ > 2 errors generated. > > geo/pgpointcloud: https://github.com/pgpointcloud/pointcloud/pull/339 > > pc_pgsql.c:47:50: error: too few arguments to function call, expected 2, have > 1 > List *names = stringToQualifiedNameList(proname); > ~~~~~~~~~~~~~~~~~~~~~~~~~ ^ > /usr/local/include/postgresql/server/utils/regproc.h:28:14: note: > 'stringToQualifiedNameList' declared here > extern List *stringToQualifiedNameList(const char *string, Node *escontext); > ^ > 1 error generated.