On Sat, September 16, 2023 04:57, Anthony J. Bentley wrote:
> Kirill Bychkov writes:
>> Attached is a port of VCMI-1.3.1, an open source Heroes
>> of Might and Magic III engine.
>> Played some campaigns and scenarios.
>
> Cool, this works with my GOG copy. Some comments:
>
> - The patches against included minizip are unnecessary since the port
> uses system minizip.
>
> - The second hunk of patch-lib_Interprocess.h seems unintentional. The
> first hunk also doesn't appear to be needed either?
>
> - Is -DUSE_FILE32API another leftover that can be removed?
>
> - CXXFLAGS=-I${X11BASE}/include can be rolled into CMAKE_CXX_FLAGS.
>
> - It takes a long time to compile, so debug packages should be enabled,
> imo.All the above was checked to work. Updated port attached. > > - Can this use GH_* instead of a self-hosted distfile, so portroach can > catch updates? > > - Looks like 1.3.2 was released this morning. > Updating was easy. But this version is amazingly buggy - I can't switch between towns while in town, the battle runs automatically. You just attack a creature on world map and after that you see a screen with battle results. So I still propose 1.3.1 for import. OKs, comments?
vcmi.tar.gz
Description: application/gzip
