On Sat, Oct 21, 2023 at 09:12:13AM +0200, Rafael Sadowski wrote: > I see two points to fix and one comment. > > - hidden dependencies? > > goldendict-1.5.0(textproc/goldendict): > Missing lib: Qt5Help.3 (/usr/local/bin/goldendict) (NOT REACHABLE) > Missing lib: Qt5Multimedia.3 (/usr/local/bin/goldendict) (NOT REACHABLE) > Missing lib: Qt5Svg.3 (/usr/local/bin/goldendict) (NOT REACHABLE) > Missing lib: Qt5WebKit.3 (/usr/local/bin/goldendict) (NOT REACHABLE) > Missing lib: Qt5WebKitWidgets.3 (/usr/local/bin/goldendict) (NOT REACHABLE) > Missing lib: Qt5X11Extras.3 (/usr/local/bin/goldendict) (NOT REACHABLE) > Missing lib: hunspell-1.7.1 (/usr/local/bin/goldendict) (NOT REACHABLE) > Missing lib: ogg.6 (/usr/local/bin/goldendict) (NOT REACHABLE) > Missing lib: vorbis.9 (/usr/local/bin/goldendict) (NOT REACHABLE) > Missing lib: vorbisfile.6 (/usr/local/bin/goldendict) (NOT REACHABLE)
I forgot to sync WANTLIB and add LIB_DEPENDS... > > - missing RUN_DEPENDS+=devel/desktop-file-utils Added, thanks. > > - I don't like the "keep it small until someone needs one of these > features" pattern. I would always recommend to start with the default > setup from upstream and only disable things when we don't have them or > they don't work. Upstream tests exactly with this default setup. > > This is just a personal opinion and not a concern. > New version that sticks to default/required CONFIG changes. OK?
goldendict.tgz
Description: application/tar-gz
