Tom Murphy wrote (2023-10-27 22:45 CEST): > Hi, > > The below diff updates databases/sqlcipher to v4.5.5. > Changes include: > > * Updates baseline to upstream SQLite 3.42.0 > * Does not allow key to be set again on a connection after it has been > successfully used for an encryption or decryption operation to prevent > accidental database corruption > * Raises an error if a rekey operation is attempted on an unencrypted > database > * Raises an error when a key or rekey operation is passed an empty key > * Minor improvements to constant time functions > * Miscellaneous code and comment cleanup > > I've bumped SHARED_LIBS based on running nm -g between the old and > new libraries and 3 functions appear to have disappered between 4.5.4 > and 4.5.5: > > sqlcipher_codec_ctx_get_flag > sqlcipher_codec_ctx_set_flag > sqlcipher_codec_ctx_unset_flag > > Based on the documentation it says to crank the major version by one, > so is 1.0 OK for this? The output of ${WRKBUILD}/shared_libs.log still > says: > > # SHARED_LIBS+= <libname> <obsd version> # <orig version> > SHARED_LIBS += sqlcipher 0.4 # 8.6 > > This is what was originally in the Makefile. Not sure if this is > correct?
I've committed this diff. This port is not a dependency within the ports tree. So this is a free shared lib bump, because nothing needs to be rebuilt because of it. The orig. version can be found when building outside of the ports infrastructure. Or when peeking into a binary package from upstream (if available). It's often tedious to find and not that important. In many ports, the orig-version comment is not set. Thanks for the update. - Stefan > Index: Makefile > =================================================================== > RCS file: /cvs/ports/databases/sqlcipher/Makefile,v > retrieving revision 1.7 > diff -u -p -u -p -r1.7 Makefile > --- Makefile 10 May 2023 08:38:21 -0000 1.7 > +++ Makefile 27 Oct 2023 20:37:14 -0000 > @@ -2,9 +2,9 @@ COMMENT = encrypted SQLite database > > GH_ACCOUNT = sqlcipher > GH_PROJECT = sqlcipher > -GH_TAGNAME = v4.5.4 > +GH_TAGNAME = v4.5.5 > > -SHARED_LIBS += sqlcipher 0.4 # 8.6 > +SHARED_LIBS += sqlcipher 1.0 # 8.6 > > CATEGORIES = databases > > Index: distinfo > =================================================================== > RCS file: /cvs/ports/databases/sqlcipher/distinfo,v > retrieving revision 1.6 > diff -u -p -u -p -r1.6 distinfo > --- distinfo 10 May 2023 08:38:21 -0000 1.6 > +++ distinfo 27 Oct 2023 20:37:14 -0000 > @@ -1,2 +1,2 @@ > -SHA256 (sqlcipher-4.5.4.tar.gz) = > 6gUv5jTXKfnda2JAFhBN55b6+H5Iep6Gigf67jWVd3E= > -SIZE (sqlcipher-4.5.4.tar.gz) = 18755568 > +SHA256 (sqlcipher-4.5.5.tar.gz) = > AU751PW19OevTZOtOZZnlHu1XjGGDmcfDe8biubwXeA= > +SIZE (sqlcipher-4.5.5.tar.gz) = 18816611 >