On 2023/11/08 12:35, Jeremie Courreges-Anglas wrote: > > I wanted to add riscv64 to APM_ARCHS because a few (mostly gui) ports > are missing from bulk builds (an important one is sysutils/upower). > machine/apmvar.h may be needed to build those ports but there is no > promise that apm(4) / apmd(8) will be available at runtime. sparc64 for > example has no apm(4) driver. > > I'm going to commit the following diff for riscv64. If people want to > add their pet architecture to the list, feel free to do so. armv7 and > powerpc64 already ship a machine/apmvar.h header.
I agree this variable is really useful for "will it build" (i.e. has apmvar.h) rather than whether apm actually does anything at runtime. Makes sense to me. > > Index: arch-defines.mk > =================================================================== > RCS file: /home/cvs/ports/infrastructure/mk/arch-defines.mk,v > diff -u -p -p -u -r1.98 arch-defines.mk > --- arch-defines.mk 7 Jun 2023 13:00:33 -0000 1.98 > +++ arch-defines.mk 8 Nov 2023 11:29:26 -0000 > @@ -16,7 +16,7 @@ ALL_ARCHS = aarch64 alpha amd64 arm arm6 > sh sparc64 > # normally only list MACHINE_ARCH (uname -p) names in these variables, > # but not all powerpc have apm(4), hence the use of macppc > -APM_ARCHS = arm64 amd64 i386 loongson macppc sparc64 > +APM_ARCHS = arm64 amd64 i386 loongson macppc riscv64 sparc64 > BE_ARCHS = hppa m88k mips64 powerpc powerpc64 sparc64 > LE_ARCHS = aarch64 alpha amd64 arm i386 mips64el riscv64 sh > LP64_ARCHS = aarch64 alpha amd64 mips64 mips64el powerpc64 riscv64 sparc64 > > > -- > jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE >
