Thanks for sending this!

On Wed, Nov 08, 2023 at 05:53:57PM -0500, Stefan S Moran wrote:

[...]

> diff -u -p -r1.46 Makefile
> --- Makefile  26 Sep 2023 09:41:41 -0000      1.46
> +++ Makefile  8 Nov 2023 22:50:19 -0000
> @@ -2,11 +2,10 @@ BROKEN-hppa =       ICE on dgn-shoals.cc:638
>  
>  COMMENT =    dungeon crawl stone soup
>  
> -VERSION =    0.27.1
> +VERSION =    0.30.1

[...]

> +@@ -1282,7 +1219,7 @@ LANGUAGES = $(filter-out en, $(notdir $(wildcard dat/d
> + SRC_PKG_BASE  := stone_soup
> + SRC_VERSION   := $(shell git describe $(MERGE_BASE) 2>/dev/null || cat 
> util/release_ver)
> + MAJOR_VERSION = $(shell echo "$(SRC_VERSION)"|$(SED) -r 
> 's/-.*//;s/^([^.]+\.[^.]+).*/\1/')
> +-RECENT_TAG    := $(shell git describe --abbrev=0 $(MERGE_BASE))
> ++RECENT_TAG    = 0.30.1

This is a bit fragile to be overlooked during updates and leading to
inconsistencies. I wonder if it would be better to use ${VERSION} and
SUBST_VARS+=VERSION and ${SUBST_CMD} path/to/file

Reply via email to