On Sat, Nov 11, 2023 at 11:35:33AM +0100, Landry Breuil wrote: > > you mean this ? > > https://github.com/openbsd/xenocara/blob/master/app/xlockmore/xlock/passwd.c#L1311 >
Yes. > sure, can add that part, but the screensavers (eg xfce, mate, gnome) i > copied the auth_userokay bits from dont have it either :) If no one complained then it's probably not really needed anymore. There were people using skey (1) in the past and asked for it in Xenodm and xlock. > https://gitlab.gnome.org/Archive/gnome-screensaver/-/blob/master/src/gs-auth-bsdauth.c?ref_type=heads#L74 > > > Also I would add an explicit_bzero(buf) after checking the password > > but I see that I didn't add it to xlock either. > > good point, will do. > > > but ok to import as is from me. we can always improve it > > in tree later. I don't know how many OpenBSD depend on that feature. > > imo proper screen locking seems like basic daily usage for regular > OpenBSD users :) > agree. -- Matthieu Herrb
