Omar Polo wrote (2023-11-13 14:08 CET): > On 2023/11/13 13:49:03 +0100, Stefan Hagen <sh+openbsd-po...@codevoid.de> > wrote: > > Hi, > > > > DIST_TUPLE did not yet make it into the Makefile.template. > > > > OK to add it under the GH_ parts? > > why not replacing GH_* completely with this in the template? There is > still stuff that explicitly depends on GH_*? (except go.port.mk)
If there's no case left for GH_, I'm not against removing it. Index: infrastructure/templates/Makefile.template =================================================================== RCS file: /cvs/ports/infrastructure/templates/Makefile.template,v diff -u -p -u -p -r1.99 Makefile.template --- infrastructure/templates/Makefile.template 15 Oct 2023 11:22:01 -0000 1.99 +++ infrastructure/templates/Makefile.template 13 Nov 2023 13:56:55 -0000 @@ -38,15 +38,15 @@ DISTNAME = ??? # # github: # /releases/ -> preferred. ignore GH_*, just use SITES and DISTNAME. -# /archive/ -> GH_ACCOUNT and GH_PROJECT, plus either GH_TAGNAME or GH_COMMIT. +# /archive/ -> use DIST_TUPLE as described below. # -# set DISTNAME if using GH_COMMIT, or if using GH_TAGNAME and the tag is not in +# set DISTNAME if using <commit>, or if using <tag> and the tag is not in # the format "v1.00" or "1.00". # -#GH_ACCOUNT = username -#GH_PROJECT = project -#GH_TAGNAME = 1.0 -#GH_COMMIT = abab123456789abacafeabab123123b1e4ble4bl +# use the dist tuple mechanism for github and other sites that are +# supported. See infrastructure/db/dist-tuple.pattern for details. +# DIST_TUPLE += <site> <account> <project> <tag/commit> <extractdir> # <license> +# DIST_TUPLE += gitlab vim vim v9.0.1677 . # VIM License / donation-ware # for any port that creates shared libraries. # both libtool and cmake automatically set filenames based on this variable.
