On 2023/12/14 18:27, Klemens Nanni wrote:
> On Thu, Dec 14, 2023 at 11:10:01AM +0300, Kirill Bychkov wrote:
> > On Fri, December 1, 2023 13:27, Kirill Bychkov wrote:
> > > Hi!
> > > Attached diff adds Qt6 FLAVOR to qtkeychain. It is
> > > needed for upcoming net/owncloudclient update.
> > > OK?
> >
> > Ping
>
> The result looks fine, but you have quite a few (trailing) space/tab issues.
> Should keychain,qt6 be hooked up?
>
> Some lines move around without changing.
>
> Two unconditional SHARED_LIBS seems off; you can use LIBNAME_L, either in
> FLAVOR blocks for unique versions or outside if qt6 can start at 2.1.
>
> LIBNAME_L could be ${LIBNAME:L} instead of duplicating the string.
>
> You could also reuse QT to pull common lines out of the FLAVOR blocks.
>
PLIST changed so a REVISION bump is needed
