> Regarding MODCARGO_WANTLIB to MODRUST_WANTLIB transition, it might be
> possible to define the first using the second (MODCARGO_WANTLIB = 
> ${MODRUST_WANTLIB}).
> But I am unsure if it would really help or not.

I am not convinced either. If it is possible, it would avoid a bit of
churn in your step 2, but that's not a strong argument.

MODRUST_BUILDDEP isn't set by any port - I think I could set it in
security/rust-openssl-tests, so having it as a special case is not a big
deal.

On the documentation side, it might look like the below. It isn't terrible.
If it leads to confusion, it might be enough to improve portcheck(1).

FWIW, I am generally ok with your plan.

Index: cargo-module.5
===================================================================
RCS file: /cvs/src/share/man/man5/cargo-module.5,v
diff -u -p -r1.7 cargo-module.5
--- cargo-module.5      18 Aug 2023 08:22:29 -0000      1.7
+++ cargo-module.5      31 Dec 2023 11:43:48 -0000
@@ -32,8 +32,11 @@
 .Nm cargo-module
 .Nd devel/cargo port module
 .Sh DESCRIPTION
+The devel/cargo module can only be used in combination with the
+lang/rust module, see
+.Xr port-modules 5 .
 This manual page documents the behavior of setting
-.Li MODULES=devel/cargo
+.Li MODULES=devel/cargo lang/rust
 in the
 .Xr ports 7
 tree.
@@ -106,7 +109,7 @@ Needs to be set for some virtual manifes
 Name of the local directory for vendoring crates.
 Defaults to
 .Pa ${WRKSRC}/modcargo-crates .
-.It Ev MODCARGO_WANTLIB
+.It Ev MODRUST_WANTLIB
 Architecture-specific
 .Ev WANTLIB
 entries required by all Rust code.

Reply via email to