On Mon, Feb 05, 2024 at 08:52:58PM -0800, Renato Aguiar wrote: > On Tue, Feb 06 2024, Klemens Nanni wrote: > > That's a lot of patches, do you intend to upstream those? > > If you do that on GitHub, you might as well switch GH_* to your fork and > > thus reduce patches/ -- just a suggestion, whatever works best for you. > > There is already a PR (from someone else) for adding support to Catch2 v3: > https://github.com/prusa3d/PrusaSlicer/pull/11576 > > Once that is merged, most patches will be removed :) > > I already keep a fork in GitHub, so I can update the port to use it in the > meantime if that is preferred.
Given that there's a PR that *might* be accepted, let's leave it for now. If the PR is rejected, we can switch to your PR; if accepted, you can remove those patches. I'll commit this version later today if no further churn.
