On Sun Feb 04, 2024 at 08:25:13AM +0100, Rafael Sadowski wrote:
> Hi ports@, hi ports hackers,
>
> I would like to get rid of 'x11/qt5/qtwebkit'. Here is a short list with
> ports using qtwebkit with some comments. All $MAINTAINER CC'd.
>
> - geo/qgis: I can't imagine that such an active project would still use it.
> - x11/qt5/qttools: Easy to remove
OK to remove qwebview? I doubt that anyone uses it for WYSIWYG
development ;)
Index: Makefile
===================================================================
RCS file: /cvs/ports/x11/qt5/qttools/Makefile,v
diff -u -p -r1.21 Makefile
--- Makefile 18 Dec 2023 12:37:10 -0000 1.21
+++ Makefile 11 Feb 2024 19:21:05 -0000
@@ -1,8 +1,6 @@
QT5NAME = QtTools
COMMENT-main = Qt development tools
-COMMENT-webview = Webkit-based Qt Designer plugin
-PKGNAME-webview = qwebview-${QT5_KDE_VERSION}
REVISION = 0
KDE_COMMIT = 16d0a9944bbd4a05edfb364bc5c28f19533a7449
@@ -10,7 +8,7 @@ KDE_VERSION = 4
DPB_PROPERTIES = parallel
-MULTI_PACKAGES = -main -examples -webview
+MULTI_PACKAGES = -main -examples
SHARED_LIBS += Qt5Designer 3.1 # 5.9
SHARED_LIBS += Qt5DesignerComponents 3.0 # 5.9
@@ -21,9 +19,6 @@ WANTLIB-main += Qt5PrintSupport Qt5Qml Q
WANTLIB-main += Qt5Sql Qt5Widgets Qt5Xml c m
WANTLIB-main += llvm${MODCLANG_VERSION}/lib/clang
-WANTLIB-webview += ${COMPILER_LIBCXX} GL Qt5Core Qt5Designer Qt5Gui Qt5Network
-WANTLIB-webview += Qt5WebKit Qt5WebKitWidgets Qt5Widgets Qt5Xml m
-
# avoid BDEP on ourselves
MODQT5_DEPS = No
@@ -38,13 +33,9 @@ LIB_DEPENDS-main = ${LIB_DEPENDS} \
${MODCLANG_LIB_DEPENDS} \
x11/qt5/qtdeclarative>=${QT5_VERSION:R},<${QT5_NEXT_VERSION}
-LIB_DEPENDS-webview = ${LIB_DEPENDS} \
- ${BUILD_PKGPATH}>=${QT5_VERSION},<${QT5_NEXT_VERSION} \
- x11/qt5/qtwebkit
-
FLAVORS = debug
-PSEUDO_FLAVORS = bootstrap no_examples no_webview
-FLAVOR ?= bootstrap no_examples no_webview
+PSEUDO_FLAVORS = bootstrap no_examples
+FLAVOR ?= bootstrap no_examples
CONFIGURE_ENV =
LLVM_INSTALL_DIR=${LOCALBASE}/llvm${MODCLANG_VERSION}
@@ -52,11 +43,5 @@ CONFIGURE_ENV = LLVM_INSTALL_DIR=${LOCA
pre-configure:
${QT5_GEN_INCLUDES}
-
-.if !${BUILD_PACKAGES:M-webview}
-post-configure:
- perl -pi -e 's/^qtHaveModule.*webkitwidgets/\# $$&/' \
- ${WRKSRC}/src/designer/src/plugins/plugins.pro
-.endif
.include <bsd.port.mk>
Index: pkg/DESCR-webview
===================================================================
RCS file: pkg/DESCR-webview
diff -N pkg/DESCR-webview
--- pkg/DESCR-webview 25 Dec 2016 14:13:14 -0000 1.1.1.1
+++ /dev/null 1 Jan 1970 00:00:00 -0000
@@ -1 +0,0 @@
-Webkit plugin for Qt Designer.
Index: pkg/PLIST-webview
===================================================================
RCS file: pkg/PLIST-webview
diff -N pkg/PLIST-webview
--- pkg/PLIST-webview 11 Mar 2022 20:17:03 -0000 1.4
+++ /dev/null 1 Jan 1970 00:00:00 -0000
@@ -1,2 +0,0 @@
-lib/qt5/cmake/Qt5Designer/Qt5Designer_QWebViewPlugin.cmake
-@so lib/qt5/plugins/designer/libqwebview.so
