El Mon, 19 Feb 2024 02:47:46 -0500 Brad Smith <b...@comstyle.com> escribió: > On 2024-02-15 7:36 p.m., Jose Maldonado wrote: > > El Thu, 15 Feb 2024 15:46:38 -0500 > > Thomas Frohwein <tfrohw...@fastmail.com> escribió: > >> On Tue, Feb 13, 2024 at 09:31:32PM -0400, Jose Maldonado wrote: > >> > >> [...] > >> > >>> +WANTLIB-main += webp x264 x265 xcb xcb-composite xcb-dri2 > >>> xcb-dri3 xcb-glx xcb-keysyms +WANTLIB-main += xcb-present > >>> xcb-randr xcb-render xcb-shm xcb-sync xcb-xfixes xcb-xv xkbcommon > >>> xml2 > >> ^ These lines are very long now; I would usually reflow them to > >> stay <= 80 chars wide. > > Fixed too. > > > >>> WANTLIB-main += xshmfence xvidcore z zstd ${WANTLIB-common} > >>> ${MODLUA_WANTLIB} # v4l2 is dlopen'd > >>> WANTLIB-main+= v4l2 > >>> @@ -113,8 +113,8 @@ LIB_DEPENDS-main= ${MODQT5_LIB_DEPENDS} > >>> devel/sdl \ > >>> devel/sdl-image \ > >>> graphics/ffmpeg \ > >>> + graphics/lcms2 \ > >>> graphics/libdvbpsi \ > >>> - graphics/libplacebo \ > >>> graphics/png \ > >>> multimedia/libass \ > >>> multimedia/libbluray \ > >>> @@ -173,6 +173,7 @@ CONFIGURE_ARGS+=--disable-a52 \ > >>> --disable-kate \ > >>> --disable-kwallet \ > >>> --disable-libmpeg2 \ > >>> + --disable-libplacebo \ > >>> --disable-libva \ > >>> --disable-linsys \ > >>> --disable-live555 \ > >>> Index: pkg/PLIST-main > >>> =================================================================== > >>> RCS file: /cvs/ports/x11/vlc/pkg/PLIST-main,v > >>> retrieving revision 1.52 > >>> diff -u -p -r1.52 PLIST-main > >>> --- pkg/PLIST-main 14 May 2023 09:20:41 -0000 1.52 > >>> +++ pkg/PLIST-main 14 Feb 2024 01:30:31 -0000 > >>> @@ -1,6 +1,5 @@ > >>> @pkgpath x11/vlc > >>> %%amd64%% > >>> -%%i386%% > >>> bin/cvlc > >>> bin/qvlc > >>> bin/rvlc > >>> @@ -444,6 +443,7 @@ lib/vlc/plugins/video_chroma/ > >>> @so lib/vlc/plugins/video_chroma/libi420_yuy2_plugin.so > >>> @so lib/vlc/plugins/video_chroma/libi422_i420_plugin.so > >>> @so lib/vlc/plugins/video_chroma/libi422_yuy2_plugin.so > >>> +%%i386%% > >>> @so lib/vlc/plugins/video_chroma/librv32_plugin.so > >>> @so lib/vlc/plugins/video_chroma/libswscale_plugin.so > >>> @so lib/vlc/plugins/video_chroma/libyuvp_plugin.so > >> Not sure if that's a change generated by update-plist, but probably > >> not the right time to adjust the order of PLIST unless this is > >> related to the libplacebo change or another compelling reason... > >> > > This is something that the maintainer can clarify better for us, but > > based on the file names, this would also be related to libplacebo. > > The PLIST-main part should be removed. The order is intentional.
Hi! I will fix this part > > >> I don't use vlc myself, but before moving forward with the > >> libplacebo update and this change to vlc, would need to hear from > >> maintainer or some others if the change for vlc is justifiable > >> here. > > It will be the last word of the maintainer. But the truth is that as > > things are with libplacebo and VLC, due to the latter we will not be > > able to update mpv either, since 0.37.0 has a strong dependency on > > libplacebo(v>=6) and with this VLC using libplacebo will not compile > > until VLC4 arrives. > > > > I don't use VLC either, but as upstream indicates, not using > > libplacebo should not remove any functionality from VLC, only that > > color management and mapping would be done with graphics/lcms2. > > > > In any case, I sent you the new diff along with an image [1] showing > > how well VLC works with the changes. > > > > [1] https://imgur.com/a/ZIGLB3I > > > I am fine with the diff disabling placebo. VLC with version 3 only > uses it for tone > mapping if I'm not mistaken, so it is not critical if it is disabled. > That's correct, it is not a functionality that interrupts the proper functioning of VLC. -- ********************************************************* Dios en su cielo, todo bien en la Tierra