On Mon, 26 Feb 2024, Sebastien Marie wrote:

> Paco Esteban <p...@e1e0.net> writes:
> 
> > Hi ports@,
> >
> > cat DESCR
> >
> >     croc is a tool that allows any two computers to simply and securely 
> > transfer
> >     files and folders.
> >     croc's features include:
> >
> >     * allow any two computers to transfer data (using a relay)
> >     * end-to-end encryption (using PAKE)
> >     * easy cross-platform transfers (Windows, Linux, Mac)
> >     * multiple file transfers
> >     * resume transfers that are interrupted
> >     * local server or port-forwarding not needed
> >     * ipv6-first with ipv4 fallback
> >     * can use proxy, like tor
> >
> > You'll notice than PLIST only contains the binary.  The only
> > documentation they include in the sources is the project README file,
> > which I'm not sure if we should include in the package.
> 
> Eventually, it could be possible add just few lines as example in DESC:
> 
> $ croc send foobar
> Sending 'foobar' (6.6 MB)
> Code is: 1767-cubic-ringo-source
> On the other computer run
> 
> croc 1767-cubic-ringo-source

After reading other comments, I added the README to ${PREFIX}/share/doc/croc/
This is markdown, so not so pleasant to read from the terminal.  But
it's something.

> > The software has a "relay" mode in which it acts as a daemon.  I did not
> > include startup scripts or reserve a system user, should we do that ?
> 
> I don't have strong opinion about it. I am fine without it, but if you
> expect users to want to setup a local relay, it might be preferable (as
> it will be properly configured at first).

I added the startup script and user in the end.  I think it's better to
have it even if the user base is small.

> > Comments and suggestions welcome.
> >
> > Ok to import ?
> 
> There is still a commented "FIX_CLEANUP_PERMISSIONS" in the Makefile.

Removed.

> Outside of that, I am fine with it. ok semarie@

Still ok ?

Here's the diff for the new user and attached the modified port:

diff /usr/ports
commit - 26872df732fc01fa20b4946684e0cbe5fe3971ff
path + /usr/ports
blob - b42938f202aa5f3563a1fbbd9b4e89d5e7a3d49a
file + infrastructure/db/user.list
--- infrastructure/db/user.list
+++ infrastructure/db/user.list
@@ -405,3 +405,4 @@ id  user            group           port
 894 _gonic             _gonic          audio/gonic
 895 _soju              _soju           net/soju
 896 _certspotter       _certspotter    security/certspotter
+897 _croc              _croc           sysutils/croc

-- 
Paco Esteban.
0x5818130B8A6DBC03

Attachment: croc.tgz
Description: application/tar-gz

Reply via email to