On Sat Mar 02, 2024 at 09:44:11AM +0100, Landry Breuil wrote:
> Le Sat, Mar 02, 2024 at 09:21:59AM +0100, Rafael Sadowski a écrit :
> > On Fri Mar 01, 2024 at 05:59:00PM +0100, Rafael Sadowski wrote:
> > > Based on landry@'s feedback, I think it makes sense to follow the
> > > qt6/qt5 pattern of x11/polkit-qt here.
> > > 
> > > I need to do a proper test with all consumers but phonon-4.12.0 updates
> > > to phonon-qt5-4.12.0p0 correct.
> > > 
> > > I would be very grateful for a review!
> > > 
> > > Rafael
> > > 
> > 
> > $ pkg_delete -X
> > $ pkg_add -D snap khtml
> > $ env TRUSTED_PKG_PATH=/usr/ports/packages/amd64/all pkg_add -u -D unsigned
> > quirks-7.10->7.12: ok
> > gettext-runtime-0.22.4->0.22.5: ok
> > giflib-5.2.1p0->5.2.2: ok
> > phonon-4.12.0->phonon-qt5-4.12.0p0 forward dependencies:
> > | Dependency of khtml-5.115.0 on phonon-* doesn't match
> > Merging khtml-5.115.0->5.115.0p0 (ok)
> > khtml-5.115.0+phonon-4.12.0->khtml-5.115.0p0+phonon-qt5-4.12.0p0: ok
> > 
> > 
> > Does that looks good to you? Unfortunately we need
> > devel/kf5/extra-cmake-modules to build both the qt5 and the qt6 part.
> 
> i havent fully followed, but your idea is to switch the port to default
> to qt6, and add a qt5 flavor, which previous consumers depend upon ?

Right, and as you can see above, it looks like it's working.

> 
> i'd have been concerned about flavors for libs causing issues/conflicts
> with bulk builds, but if that works for polkit-qt... 
> 

Me too and I'm too stupid for it, but the polkit-qt looks good and
phonon can profit from the same pattern.

I would like to have this in 7.5.

Reply via email to