On Sun, Mar 03, 2024 at 04:26:14PM +0100, Peter Hessler wrote:
> This fails to build for me on arm64:
>
> ===> Configuring for aom-3.8.1
> -- The C compiler identification is Clang 16.0.6
> -- The CXX compiler identification is Clang 16.0.6
> -- Detecting C compiler ABI info
> -- Detecting C compiler ABI info - done
> -- Check for working C compiler: /usr/obj/ports/aom-3.8.1/bin/cc - skipped
> -- Detecting C compile features
> -- Detecting C compile features - done
> -- Detecting CXX compiler ABI info
> -- Detecting CXX compiler ABI info - done
> -- Check for working CXX compiler: /usr/obj/ports/aom-3.8.1/bin/c++ - skipped
> -- Detecting CXX compile features
> -- Detecting CXX compile features - done
> -- Performing Test CMAKE_HAVE_LIBC_PTHREAD
> -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
> -- Looking for pthread_create in pthreads
> -- Looking for pthread_create in pthreads - not found
> -- Looking for pthread_create in pthread
> -- Looking for pthread_create in pthread - found
> -- Found Threads: TRUE
> --- aom_configure: Detected CPU: arm64
> -- The ASM compiler identification is unknown
> -- Found assembler: as
> CMake Error at build/cmake/aom_configure.cmake:212 (enable_language):
> The CMAKE_ASM_COMPILER:
>
> as
>
> is not a full path and was not found in the PATH.
>
> Tell CMake where to find the compiler by setting either the environment
> variable "ASM" or the CMake cache entry CMAKE_ASM_COMPILER to the full path
> to the compiler, or to the compiler name if it is in the PATH.
> Call Stack (most recent call first):
> CMakeLists.txt:73 (include)
>
>
> -- Warning: Did not find file Compiler/-ASM
> -- Configuring incomplete, errors occurred!
>
>
> note that there is no "as" or "llvm-as" binary on arm64.
Try the following.
Index: patches/patch-build_cmake_aom_configure_cmake
===================================================================
RCS file: patches/patch-build_cmake_aom_configure_cmake
diff -N patches/patch-build_cmake_aom_configure_cmake
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-build_cmake_aom_configure_cmake 3 Mar 2024 21:29:37
-0000
@@ -0,0 +1,16 @@
+ARM uses compiler intrinsics, so don't require GNU as.
+
+Index: build/cmake/aom_configure.cmake
+--- build/cmake/aom_configure.cmake.orig
++++ build/cmake/aom_configure.cmake
+@@ -192,6 +192,10 @@ elseif(AOM_TARGET_CPU MATCHES "arm")
+ if(NOT CMAKE_ASM_COMPILER)
+ set(CMAKE_ASM_COMPILER ${CMAKE_C_COMPILER} -c -mimplicit-it=always)
+ endif()
++ elseif(AOM_TARGET_SYSTEM STREQUAL "OpenBSD")
++ if(NOT CMAKE_ASM_COMPILER)
++ set(CMAKE_ASM_COMPILER ${CMAKE_C_COMPILER})
++ endif()
+ else()
+ if(NOT CMAKE_ASM_COMPILER)
+ set(CMAKE_ASM_COMPILER as)
