On Sun, Mar 10, 2024 at 06:26:04PM +0100, Omar Polo wrote:
> On 2024/03/03 20:37:45 -0700, gkoeh...@openbsd.org wrote:
> > http://build-failures.rhaalovely.net/powerpc/2024-02-07/games/nanosaur2.log
>
> :
> /usr/obj/ports/nanosaur2-2.1.0/Nanosaur2-2.1.0/Source/Headers/ogl_support.h:122:2:
> : error: unknown type name 'vector'
> : vector float v[4];
> : ^
> : 1 error generated.
>
> I missed this failure, thanks izzy for prodding me. I don't have a
> powerpc to test this, but it appears if I'm grepping correctly that this
> field is never used.
>
> (no bump needed since it only fixes -hopefully- the build on powerpc
> where it wasn't built before.)
>
> The alternative, if I'm reading this[0] correctly, is to sprinkle some
> #include <altivec.h> and -maltivec, but since it's not used I think it's
> easier to just remove it. If it works I'll upstream this as well.
>
> [0]:
> https://gcc.gnu.org/onlinedocs/gcc/PowerPC-AltiVec_002fVSX-Built-in-Functions.html
I actually built and tested this a few weeks back. I just removed all the
#ifdef __ppc__ blocks. Game loads but runs with ~5 fps and crashes after
a few seconds on my powerbook G4
Do we actually support ppcs without altivec? I guess it might work better
with altivec enabled instead.
>
>
> Thanks!
>
> Omar Polo
>
>
> Index: patches/patch-Source_Headers_ogl_support_h
> ===================================================================
> RCS file: patches/patch-Source_Headers_ogl_support_h
> diff -N patches/patch-Source_Headers_ogl_support_h
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ patches/patch-Source_Headers_ogl_support_h 10 Mar 2024 17:12:47
> -0000
> @@ -0,0 +1,16 @@
> +fixes "error: unknown type name 'vector'" on powerpc; the v field is
> +never used.
> +
> +Index: Source/Headers/ogl_support.h
> +--- Source/Headers/ogl_support.h.orig
> ++++ Source/Headers/ogl_support.h
> +@@ -118,9 +118,6 @@ typedef struct
> + typedef union
> + {
> + GLfloat value[16];
> +- #if defined(__ppc__)
> +- vector float v[4];
> +- #endif
> + }OGLMatrix4x4;
> +
> + typedef struct
>
