On Fri, Apr 19, 2024 at 07:10:12PM -0400, Russ Sharek wrote:
> > > Is `ALL_TARGET = github.com/s0rg/crawley@v1.7.5` needed?
> > 
> > I couldn't get it to build without.
> 
> And a moment later, I realized that I was wrong. :)
> 
> Revision attached. Thank you!

So... Edd asked for feedback.

A few nits:
- the port doesn't install any doc and DESCR is rather light.  I
  understand the tool is simple but still, it would be nice to at least
  have the examples from the README.  Maybe just install that file under
  share/doc/crawley?
- make test fails for bad reasons and I don't know how to fix that.
  NO_TEST=Yes?

I definitely don't consider myself as an expert on go ports but LGTM
ports-wise.  ok jca@ but I'd prefer to have at least the ''make test''
issue addressed, even if papered over.

-- 
jca

Reply via email to