On 2024/05/29 11:52:49 +0100, Kirill A. Korinsky <kir...@korins.ky> wrote: > On Wed, 29 May 2024 09:14:43 +0100, > Stuart Henderson <s...@spacehopper.org> wrote: > > > > Reattached to make it easier for anyone who wants to look. > > > > I'm not familiar enough with m4 to know if the changes in > > patch-configure make sense. > >
same for me, it's a bit over my head > To make it easy for review I made diff between 2.71 and 2.72. > > It seems trivial and srigthforward with expection of two hunks, both of them > seems to related to remove check for GNU M4, and the code which is removed > as updated to with code base which requires at least M4 1.4.8. ...but since they match what we do for 2.71 I guess it's fine :) > [...] > So, as far as I understand it (compiled output of m4 is quite difficult to > understand BTW) everything is legitim and fine. > > Thus, I had brifly tested in ot -current/amd64 and confirm that it works. Same here, I tested with a few projects I had around (make distclean; export AUTOCONF_VERSION=2.72; ./autogen.sh && ./configure) and works just as fine as 2.71. Thanks! Omar Polo
