Hi Johannes, Hi ports@

thanks for your hard work on PySide6. It was a good starting point for
me. (I took the latest tarball)

First of all, what have I done:

- I moved pyside6 into x11/qt6. I would like to have it closely with Qt6
  so that we can update it together.
- Update to 6.6.2. Unfortunately, there was never a 6.6.3
- I moved all tools into bin/pyside6/* Idea from FeeBSD (as you already 
mentioned):
  
https://github.com/freebsd/freebsd-ports/blob/main/devel/pyside6-tools/Makefile#L35
- I've left you as a MAINTAINER. Is that okay with you?
- BUILD_TESTS=OFF It's broken FreeBSD and Archlinux also disabled it.
- ${MODPY_COMPILEALL} from sthen@

Feedback, OKs to import welcome.

... some more note below:


? pyside6
? qtgraphs
Index: Makefile.version
===================================================================
RCS file: /cvs/ports/x11/qt6/Makefile.version,v
diff -u -p -r1.13 Makefile.version
--- Makefile.version    27 Mar 2024 16:24:36 -0000      1.13
+++ Makefile.version    2 Jun 2024 08:30:10 -0000
@@ -4,3 +4,5 @@ QT6_VERSION =           6.6.3
 # This one is used for building dependencies for examples and documentation,
 # which obviously should be in sync with core packages.
 QT6_NEXT_VERSION =     6.7.0
+
+PYSIDE_VERSION =       6.6.2


On Tue Sep 19, 2023 at 10:07:31PM GMT, Johannes Thyssen Tishman wrote:
> Hi everyone,
> 
> I'm currently working on porting the following three FreeCAD
> dependencies:
> 
> PySide6: Python Qt bindings for Qt 6
> PySide6-tools: PySide6 development tools
> Shiboken6: Python binding generator for C++ libraries
> 
> Since their sources are provided as a single tarball, I think they
> should be ported as sub-packages of one port with MULTI_PACKAGES.
> However this is the first time I'm trying to use this feature and I'm
> struggling to make it work. I initially made a separate port for each of
> them by adapting ${WRKSRC} so that I could tell their *_DEPENDS,
> WANTLIBs and PLISTs apart. Now that all three ports are finished, I've
> merged them into one and suffixed their specific COMMENT, WANTLIB and
> {LIB,RUN}_DEPENDS accordingly with a sub-package name. 
> 
> The problem is that the PySide6 (-main) sub-package depends on the
> SHARED_LIBS installed by the Shiboken6 (-shiboken) sub-package, which of
> course is throwing me an error. I know that library interdependencies
> between sub-packages are possible since bsd.port.mk(5) mentions the
> following:
> 
> > ... any LIB_DEPENDS-sub that references the current port will be
> > ignored as a build dependency, in order to avoid recursion. ...
> 
> So how can I make this work? Is it possible to have a sub-package depend
> on another sub-package SHARED_LIBS? FreeBSD has separate ports for each
> of these dependencies[1][2][3], but for example the Arch Linux port
> seems to be only one with multiple packages[4].

I don't think that MULTI_PACKAGES is possible.

> 
> Another issue that I'm having is that the Shiboken6 port installs both
> libraries and a Python module, so I'm not sure if this should be split
> as well. What is the convention in this kind of case?
> 
> Lastly, when running 'make port-lib-depends-check' for both Shiboken6
> and PySide6-tools, I'm getting a warning like the following:
> 
> > Missing lib: clang.8 (/usr/local/bin/shiboken6) (NOT REACHABLE)

I added "WANTLIB += llvm${MODCLANG_VERSION}/lib/clang" and ignored the
known issue

> 
> I think this is due to clang being a runtime dependency for this ports.
> I've had a similar issue in the past with another port and, if I
> remember correctly, this was due to the library not being present in
> LIB_DEPENDS. However here I've tried adding devel/llvm/13 to LIB_DEPENDS
> and using the lang/clang module and I'm still getting the error. Any
> idea what could be causing this?
> 
> Apologies in advance for the many questions. I've attached both the
> combined port and the individual ones in case anyone wants to check them
> out. I'd be very grateful for any guidance or feedback anyone could
> provide.
> 
> Thank you.
> 
> Kind regards,
> Johannes Thyssen Tishman

Thanks for your work again

> 
> [1] https://github.com/freebsd/freebsd-ports/tree/main/devel/pyside6
> [2] https://github.com/freebsd/freebsd-ports/tree/main/devel/pyside6-tools
> [3] https://github.com/freebsd/freebsd-ports/tree/main/devel/shiboken6
> [4] 
> https://gitlab.archlinux.org/archlinux/packaging/packages/pyside6/-/blob/main/PKGBUILD?ref_type=heads
> 

Attachment: pyside6.tar.gz
Description: application/tar-gz

Reply via email to