Hi,

thanks for your review.

-WANTLIB =              ${COMPILER_LIBCXX} c m
+WANTLIB =              ${LIBCXX} c m

${COMPILER_LIBCXX} was already correct.

ok. I'll keep COMPILER_LIBCXX. Is this documented somewhere? bsd.port.mk only knows about LIBCXX.

+
+COMPILER =             base-clang base-gcc

C++ programs in ports should all prefer ports-gcc over base-gcc except
in special cases. Basically you can't have a mix of C++ programs and
libraries using base-gcc and ports-gcc otherwise there are library
conflicts, and on those archs which still use gcc in base the majority
of C++ things in ports require more recent GCC. So: this should use
"base-clang ports-gcc", or possibly "base-clang ports-gcc base-gcc".

Ok. I'll change this to "base-clang ports-gcc". But since opam installs only two binaries this shouldn't matter, should it?

OK with those two changes? Daniel?


Christopher

Reply via email to