Checking back to see if there is any feedback on this submission or if it can be included in the next update
On Mon, Feb 12, 2024 at 12:31 PM JR Aquino <tana...@gmail.com> wrote: > Thank you for the feedback Stuart! > > Attached is the updated tarball with corrections. > > > - don't use REVISION in a new port > Removed > > > - there's a lot of indirection with variables DATADIR MODULESDIR RUNDIR > etc that seem unnecessary and are not usually don in ports > Corrected > > > - MESSAGE should never be more than a couple of lines anyway and kept > for very important messages; standard install type docs go in pkg/README. > Removed MESSAGE and created README > > > - now that most people are using acme-client etc it doesn't make much > sense to include the "this is how you use the openssl demo program to > make a certificate" instructions. > Removed > > > - don't copy the HOMEPAGE into DESCR, it is added automatically. really > it wants more info about the software in there. "the next generation ircd" > doesn't give any information about what this does (and how it's different > from other IRCds, for example "ngircd" which also calls itself "next > generation ircd". > Updated DESCR > > > - by putting @owner _unrealircd at the top of the PLIST you are > installing all the files (daemon, dlopen'd libraries, etc) owned by > the user the daemon runs as! this is totally nuts. things shouldn't > be owned by the daemon user unless the daemon needs to write to them. > Acknowledged, good catch! This has been corrected. > > > - docs go in the /usr/local/share/doc/(portname), sample configs in > /usr/local/share/examples(portname) > Corrected paths > > Thanks again for the feedback, please let me know if things are looking > better for inclusion in ports for OpenBSD 7.5. > > -JR > > On Fri, Oct 27, 2023 at 8:20 AM Stuart Henderson <s...@spacehopper.org> > wrote: > >> On 2023/10/27 07:32, JR Aquino wrote: >> > Are there any remaining items that either of you see needing to be >> > addressed before this can be committed? >> >> Yes but I don't have time (and really at the moment enough interest to >> spend the time if I did) to go through it all carefully at the moment. >> >> A few things I noticed from a quick read through >> >> - don't use REVISION in a new port >> - there's a lot of indirection with variables DATADIR MODULESDIR RUNDIR >> etc that seem unnecessary and are not usually done in ports >> - MESSAGE should never be more than a couple of lines anyway and kept >> for very important messages; standard install type docs go in pkg/README. >> - now that most people are using acme-client etc it doesn't make much >> sense to include the "this is how you use the openssl demo program to >> make a certificate" instructions. >> - don't copy the HOMEPAGE into DESCR, it is added automatically. really >> it wants more info about the software in there. "the next generation ircd" >> doesn't give any information about what this does (and how it's different >> from other IRCds, for example "ngircd" which also calls itself "next >> generation ircd". >> - by putting @owner _unrealircd at the top of the PLIST you are >> installing all the files (daemon, dlopen'd libraries, etc) owned by >> the user the daemon runs as! this is totally nuts. things shouldn't >> be owned by the daemon user unless the daemon needs to write to them. >> - docs go in /usr/local/share/doc/(portname), sample configs in >> /usr/local/share/examples/(portname) >> >>
