On 24-06-24 17:35:07, Jeremie Courreges-Anglas wrote: > On Sun, Jun 23, 2024 at 01:56:44AM +1000, Joel Sing wrote: > > The openbsd/mips64 port is effectively unmaintainable. I've been > > trying to upstream the direct syscall to libc conversion for two > > years now: > > > > https://github.com/golang/go/issues/61546 > > > > Currently, I'm carrying a bunch of extra diffs in ports, I have > > limited working hardware to build/test on and when it was broken > > in ports for multiple months, no one seemed to notice. > > > > I think it's time to simply give up. > > No opinion on that. Kudos for trying! > > > The below removes mips64 from GO_ARCHS, along with armv7 which > > seems like it should not be there. > > Looks correct, arch-defines.mk talks about MACHINE_ARCH which should > be "arm" according to arch/arm/include/param.h. I can't verify this > on a live system though. > > > Remove mips64 from the > > lang/go Makefile and sort the MACHINE_ARCH handling list. > > Do the same in go.port.mk, however add riscv64 (neither mips64 > > or riscv64 were there - not sure what the impact was). > > No idea either. I added this on top of the previous riscv64 bulk > build, and it didn't magically fix the go ports that fail. Not very > surprising, AFAIK the problem with most/all of those ports lies within > module deps that are too old to know about openbsd/riscv64. In the > unlikely event of a regression on riscv64, we can fix it up.
If you have a list of failures I'm happy to take a look. I sent out diffs for go.port.mk some time ago that made it easy to patch/fix these kinds of issues, however was unable to get any traction on it. > > P.S. I'll deal with the removal of mips64 specific patches in the > > upcoming Go 1.23 bump. > > You also should remove the mips64 bootstraps from distinfo, as dpb(1) > would error out trying to download them. Except for this, LGTM. Fixed, thanks.
