On Tue, Jul 16, 2024 at 11:57:38PM +0200, Tobias Heider wrote:
> On Tue, Jul 16, 2024 at 06:41:02PM +0200, Lorenz (xha) wrote:
> > On Tue, Jul 16, 2024 at 12:49:40PM +0200, Tobias Heider wrote:
> > > On Tue, Jul 16, 2024 at 12:31:02PM +0200, Tobias Heider wrote:
> > > > On Mon, Jul 15, 2024 at 09:40:40PM -0700, Renato Aguiar wrote:
> > > > > Diff updating lang/hare to 0.24.2:
> > > > > 
> > > > 
> > > > Here is an inline version of the patch with Lorenz in CC
> > > > I'll comment in-line in a follow-up mail
> > > > 
> > > 
> > > Whoopsie, sent the wrong hare.patch
> > 
> > great, much faster update than me :D
> > 
> > looks good to me, thank you!
> 
> Thanks, committed Renato's update!
> 
> I wonder if we should also move the harec dependency to BUILD_DEPENDS
> and try a little harder to keep hare and harec in sync. It looks like
> hare will only build with a matching harec version.
> 
> opinions?

haven't thought about the two getting out of sync, nothing would
work after that! i like your patch. although i think that harec
should keep being a runtime dependency. the `hare` binary is just
a build driver after all.

> Index: Makefile.inc
> ===================================================================
> RCS file: /cvs/ports/lang/hare/Makefile.inc,v
> retrieving revision 1.4
> diff -u -p -r1.4 Makefile.inc
> --- Makefile.inc      21 Feb 2024 23:30:40 -0000      1.4
> +++ Makefile.inc      16 Jul 2024 21:54:53 -0000
> @@ -6,6 +6,8 @@ CATEGORIES ?= lang devel
>  
>  HOMEPAGE ?=  https://harelang.org/
>  MAINTAINER ?=        Lorenz (xha) <m...@xha.li>
> +V ?=         0.24.2
> +REVISION ?=  0
>  
>  # Compiler: GPLv3 only
>  # Runtime: MPL 2.0
> Index: hare/Makefile
> ===================================================================
> RCS file: /cvs/ports/lang/hare/hare/Makefile,v
> retrieving revision 1.4
> diff -u -p -r1.4 Makefile
> --- hare/Makefile     16 Jul 2024 20:08:39 -0000      1.4
> +++ hare/Makefile     16 Jul 2024 21:54:53 -0000
> @@ -1,13 +1,10 @@
> -V =          0.24.2
>  DISTNAME =   hare-${V}
>  DISTFILES =  hare-{hare/archive/}${V}${EXTRACT_SUFX}
>  
>  WANTLIB += c
>  
> -BUILD_DEPENDS =      ${RUN_DEPENDS} \
> +BUILD_DEPENDS =      lang/hare/harec=${V} \
>               textproc/scdoc
> -
> -RUN_DEPENDS =        lang/hare/harec
>  
>  MAKE_FLAGS = MANDIR="${PREFIX}/man"
>  
> Index: harec/Makefile
> ===================================================================
> RCS file: /cvs/ports/lang/hare/harec/Makefile,v
> retrieving revision 1.5
> diff -u -p -r1.5 Makefile
> --- harec/Makefile    16 Jul 2024 20:08:39 -0000      1.5
> +++ harec/Makefile    16 Jul 2024 21:54:53 -0000
> @@ -1,4 +1,3 @@
> -V =          0.24.2
>  DISTNAME =   harec-${V}
>  DISTFILES =  harec-{harec/archive/}${V}${EXTRACT_SUFX}
>  

Reply via email to