Dear maintainers, I'm writing you because your email address is listed on repology[0] as a contact for your distro's w3m package. I want to inform you that development at the canonical upstream repo at GitHub has stalled, see [1] for details. I like to ask you to apply the patch below which fixes an annoying user facing bug[2] where the history does not get written if no history file exists. Thanks to fcd for providing the patch! The patch applies to the latest release v0.5.3+git20230121.
More bug fixes are available through my fork[2]. I invite you to follow the development there. I already merged patches to my master branch that allow building w3m with the most recent version of GCC without warnings. Please report bugs and problems to the mailing list[4]. I have dozens outstanding patches, chances are that the problem might already be addressed. Also please contact me if you want me to send bug fix patches directly to you. [0]: https://repology.org/project/w3m/versions [1]: https://github.com/tats/w3m/issues/304 [2]: https://github.com/tats/w3m/issues/280 [3]: https://sr.ht/~rkta/w3m [4]: mailto:~rkta/w...@lists.sr.ht ---- >8 ---- >From 9ebc5a1db6f25b595ced196d8976fb76688d0fd1 Mon Sep 17 00:00:00 2001 From: fcd <g...@fcd.dev> Date: Sun, 30 Jul 2023 15:54:07 +0300 Subject: [PATCH] Create history file if it doesn't exist When history is enabled but there is no history file, w3m logs an error message. Change that behavior to create a history file if it doesn't exists. --- history.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/history.c b/history.c index 0c427ff3..d0ec5e23 100644 --- a/history.c +++ b/history.c @@ -90,9 +90,7 @@ saveHistory(Hist *hist, size_t size) return; histf = rcFile(HISTORY_FILE); - if (stat(histf, &st) == -1) - goto fail; - if (hist->mtime != (long long)st.st_mtime) { + if (!stat(histf, &st) && hist->mtime != (long long)st.st_mtime) { fhist = newHist(); if (loadHistory(fhist) || mergeHistory(fhist, hist)) disp_err_message("Can't merge history", FALSE); -- 2.45.0.rc0
