On Saturday, January 11, 2025 at 05:04:17 a.m. EST, Stuart Henderson
<[email protected]> wrote:
On 2025/01/11 09:50, Stuart Cassoff wrote:> Excellent, thanks!
>
> Now 1 failure on amd64 and 4 on i386. Pretty good.
actually I missed another part,
pre-test:
cd ${WRKSRC}/neomutt-test-files; ./setup.sh
> Ok to update?
yes.
Nice. That necessitates FIX_CLEANUP_PERMISSIONS :)
All tests pass on amd64, 3 fail on i386.
Here's the update I'll put in later if nothing else comes up.
Here also are the test failures, if you're into that sort of thing.
Stu
Index: Makefile
===================================================================
RCS file: /cvs/ports/mail/neomutt/Makefile,v
diff -u -p -u -p -r1.99 Makefile
--- Makefile 9 Jan 2025 12:30:43 -0000 1.99
+++ Makefile 11 Jan 2025 16:13:16 -0000
@@ -4,6 +4,9 @@ GH_ACCOUNT= neomutt
GH_PROJECT= neomutt
GH_TAGNAME= 20250109
+DIST_TUPLE= github neomutt neomutt-test-files \
+ 7404f4423b11cd5da2d123b3636c7a310bbbed9f neomutt-test-files
+
CATEGORIES= mail
HOMEPAGE= https://neomutt.org/
@@ -50,6 +53,8 @@ CONFIGURE_ENV= autosetup_tclsh="${LOCALB
SYSCONFDIR= ${BASESYSCONFDIR}/mutt
FAKE_FLAGS= sysconfdir="${PREFIX}/share/examples/neomutt"
+TEST_FLAGS= NEOMUTT_TEST_DIR=${WRKSRC}/neomutt-test-files
+FIX_CLEANUP_PERMISSIONS= Yes
.if ${FLAVOR:Mgpgme}
CONFIGURE_ARGS+= --autocrypt \
@@ -78,5 +83,8 @@ LIB_DEPENDS+= databases/kyotocabinet
WANTLIB+= kyotocabinet
CONFIGURE_ARGS+= --kyotocabinet
.endif
+
+pre-test:
+ cd ${WRKSRC}/neomutt-test-files; ./setup.sh
.include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: /cvs/ports/mail/neomutt/distinfo,v
diff -u -p -u -p -r1.65 distinfo
--- distinfo 9 Jan 2025 12:30:43 -0000 1.65
+++ distinfo 11 Jan 2025 16:13:16 -0000
@@ -1,2 +1,4 @@
SHA256 (neomutt-20250109.tar.gz) = WXMlwjrQcxDtlrLuVm5F5InMqBsL2wKPJ2xpAUNQD4o=
+SHA256
(neomutt-neomutt-test-files-7404f4423b11cd5da2d123b3636c7a310bbbed9f.tar.gz) =
5DLXwXB6Jbri3VKiHh3SC/k44TcZ2Up4Om3q7S7slGI=
SIZE (neomutt-20250109.tar.gz) = 4099634
+SIZE
(neomutt-neomutt-test-files-7404f4423b11cd5da2d123b3636c7a310bbbed9f.tar.gz) =
10603
Test test_mutt_date_parse_date... [ FAILED ]
Case Thu, 16 Aug 2001 16:01:08 IST+530:
mutt_date_parse_date.c:143: result == parse_tests[i].expected... failed
Expected: 997970468
Actual : 997977668
Case Tue, 19 Dec 2000 19:33:09 MET-1:
mutt_date_parse_date.c:143: result == parse_tests[i].expected... failed
Expected: 977250789
Actual : 977254389
Case Wed, 13 Jun 2007 12:34:56 MET DST:
mutt_date_parse_date.c:143: result == parse_tests[i].expected... failed
Expected: 1181734496
Actual : 1181738096
Test test_mutt_parse_mailto... [ FAILED ]
Case Common setup:
mutt_parse_mailto.c:91: mutt_parse_mailto(env, &parsed_body, mailto)...
failed
Expected: parsed
<mailto:[email protected][email protected],[email protected]&body=Some%20text%20-%20it%20should%20be%20pct-encoded>
Actual : NULL
Expected: parsed [email protected] (...)
Actual : not parsed
mutt_parse_mailto.c:51: test_check_str_eq... failed
Expected : '[email protected]'
Actual : '(null)'
Expected: parsed [email protected] (...)
Actual : not parsed
mutt_parse_mailto.c:51: test_check_str_eq... failed
Expected : '[email protected]'
Actual : '(null)'
mutt_parse_mailto.c:51: test_check_str_eq... failed
Expected : '[email protected]'
Actual : '(null)'
mutt_parse_mailto.c:98: test_check_str_eq... failed
Expected : 'Some text - it should be pct-encoded'
Actual : '(null)'
One like:
Test test_url_parse... neomutt-test(8242) in malloc():
write to free mem 0x633a4020[24..31]@32
Test interrupted by SIGABRT.
Test test_url_parse... neomutt-test(9622) in free():
write to free mem 0x626e8690[40..47]@48
Test interrupted by SIGABRT.
Test test_url_parse... neomutt-test(29816) in
calloc(): write to free mem 0x7d3c1330[40..47]@48
Test interrupted by SIGABRT.
