On 2025/01/12 22:22, Julius Drodofsky wrote:
quick comments;
> +++ ports_new/games/mines-tui/Makefile Sun Jan 12 22:55:48 2025
please send a tar for new ports, it's easier for committers to work with
> +COMMENT = terminal based Minesweeper implementation
I would s/implementation/game/ here
> +V = 1.0
> +DISTNAME = mines-tui-${V}
> +CATEGORIES = games
> +REVISION = 0
don't use REVISION in a new port
> +
> +HOMEPAGE = https://github.com/Judro/mines
> +MAINTAINER = Julius Drodofsky <[email protected]>
> +
> +# BSD
> +PERMIT_PACKAGE = Yes
> +
> +SITES = https://github.com/Judro/mines/releases/download/v1.0.0/
normally I would suggest using ${V} here but they don't currently align
(1.0 vs 1.0.0).
> +
> +For further information, check the man page.
that's expected anyway and doesn't really need to go in DESCR,
imagone if we did that for all ports with manuals.
> +@bin bin/mines-tui
> +@man man/man6/mines-tui.6
> +@exec mkdir -m 0777 -p /var/games/mines/save
> +@unexec rm -r /var/games/mines
in general: the dir should be created with @sample and should only be
removed if pkg_delete -c is used (by using @extraunexec). for that, you
could use something like this instead,
@extraunexec rm -r /var/games/mines/save
@sample /var/games/mines/
@mode 0777
@sample /var/games/mines/save/
*however* the world-writable dir means that in most cases (unless e.g.
/var/games is a separate filesystem), if the package is installed, any
user can fill all space in a partition used for important system files.
We don't want that.
Games in base using a shared dir under /var/games just for score files
have been converted to place scores in $HOME instead and that would be
preferred here too.
(there are a few in base which use a shared dir for other purposes e.g.
comms between multiple users playing at the same time and those have
been broken for ~9 years since we stopped using "setgid games").
