On Sun, Jan 26, 2025 at 07:28:26PM -0500, Brad Smith wrote: > On 2025-01-21 7:19 a.m., Alexandre Ratchov wrote: > > Sometimes the audio increase/decrease volume command are stuck to a > > fixed value. This diff fixes this problem. > > > > The hot-keys for above commands are the volume keys of multimedia > > keyboards. These keys are already used by the OpenBSD kernel for other > > volume adjustments; probably, that's why this problem stayed > > unnoticed. > > > > OK? > > I can't test this. But I guess it's Ok. > > Also what about the comment just below this in Open(). > > |/* FIXME:set volume/mute here */| > > Does anything else need to be done there or should the comment > simply be removed? >
The diff doesn't touch this part of the code so I see no reason to remove it. Upon exit vlc saves the volume and restores it the next time it's started. This overwrites sndiod(8)'s setting for vlc which is slightly unusual but not a problem IMHO. Maybe the comment is about fixing this, sur sure...
