On Mon, Feb 10, 2025 at 12:45:27AM -0500, George Koehler wrote:
> On Fri, 7 Feb 2025 15:29:57 -0800
> Andrew Hewus Fresh <[email protected]> wrote:
>
> > -sub new {
> > - my ($class, $dir, $tweak_wantlib, $lib_depends_tgt) = @_;
> > +sub new($class, $dir, $tweak_wantlib, $lib_depends_tgt = undef) {
>
> > -sub verbose {
> > - my $self = shift;
> > +sub verbose($self, $set = undef) {
>
> > -sub _adj_whitespace {
> > - my ($self, $var, $value, $wssample) = @_;
> > -
> > +sub _adj_whitespace($self, $var, $value, $wssample = undef) {
>
> Do we need "= undef" in these 3 signatures? The callers seem to pass
> all arguments, so I deleted all 3 "= undef" in my copy. All of your
> signatures look correct to me.
Need is strong, probably we don't, but the code handled it as if it were
optional, so I didn't look hard at the uses.
> You have multiple "use v5.40;" lines, one in each package. It is
> correct, but I would prefer to have only one "use v5.40;" above the
> 1st "package" line.
I can do that, I just keep things this way so that if I pull them into
separate files it will still be there.
That seems unlikely in this case. I'll look again.
l8rZ,
--
andrew
I think I understand, but my stubborn brain refuses to admit it
until I beat it into submission by proof upon proof.
-- Michael Shiloh <[email protected]>
