On Fri, Jan 09, 2026 at 12:50:51AM +1100, Jonathan Gray wrote: > On Wed, Jan 07, 2026 at 03:30:56PM +0100, Theo Buehler wrote: > > Fix the build of piglit with numpy 2.4.0 which removed newshape > > and the compat glue assigning it to shape. The build fails with: > > > > File > > "/work/pobj/piglit-20250507/piglit-20250507/generated_tests/builtin_function.py", > > line 296 > > , in column_major_values > > return list(np.reshape(value, newshape=-1, order='F')) > > ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > TypeError: reshape() got an unexpected keyword argument 'newshape' > > > > Fix this and a similar problem in the fp64 variant. This also > > builds with in-tree py3-numpy-2.2.6p2. > > > > Since upstream piglit pinned numpy to 1, they don't have such a fix > > (and they would probably need to drop the 'shape=' part of the diffs) > > There is an open merge request with the same diff > https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/1063
Great - I think that wasn't there yet when I wrote the diff. Thanks. If you have an account on their GitLab, could you suggest they drop the 'shape=' thus making the -1 a positional argument? shape is only available since numpy 2 IIRC.
