On Fri, 09 Jan 2026 20:28:40 +0100
Kirill A. Korinsky <[email protected]> wrote:
> On Thu, 08 Jan 2026 23:18:57 +0100,
> Thomas Frohwein <[email protected]> wrote:
> >
> > PS: there is a precedent: games/devilutionx also has Sustainable Use
> > License 1.0 and is PERMIT_PACKAGE=Yes
>
> I see, when it seems that I had too pesimistic view for the world.
>
I reviewed the port fallout1-ce. It works here, but only with the
included CFLAGS=-O1 -pipe, which bugs me that it's not clear why -O2
crashes. I'm attaching the backtrace from the corefile, in case anyone
can make sense why only O2+ crashes here.
In general, it's probably easier to figure out the open questions for
one of the ports first, rather than discussing both together. Once we
got it sorted out, knowing how to deal with the other port will
probably be more straightforward, given the similarities.
Regarding the other issues that have been raised:
1) I'm in favor of CATEGORIES=games x11, as it puts the most relevant
category first.
2) I don't have an opinion on fpattern as a port. For sake of moving
things along, I'd suggest that we consider importing fallout1-ce with
the bundled fpattern first. We can later see after a possible fpattern
port about using that rather than the bundled one.
3) README is clear enough for me as is.
4) We should be able to do just PERMIT_PKG=Yes like games/devilutionx
which has the same license.
From my side ok thfr@ to import fallout1-ce, with the change to
CATEGORIES in 1).
Program terminated with signal SIGSEGV, Segmentation fault.
#0 fallout::ai_danger_source (critter=0x6fadef26d0)
at
/usr/ports/pobj/fallout1-ce-1.1.0/fallout1-ce-1.1.0/src/game/combatai.cc:602
602 if ((who_hit_me->data.critter.combat.results & DAM_DEAD) == 0) {
[Current thread is 1 (process 155464)]
(gdb) bt full
#0 fallout::ai_danger_source (critter=0x6fadef26d0)
at
/usr/ports/pobj/fallout1-ce-1.1.0/fallout1-ce-1.1.0/src/game/combatai.cc:602
who_hit_me = 0x0
targets = <optimized out>
index = <optimized out>
#1 0x0000006d0f0aad65 in fallout::combatai_want_to_join (a1=0x6fadef26d0)
at
/usr/ports/pobj/fallout1-ce-1.1.0/fallout1-ce-1.1.0/src/game/combatai.cc:1290
No locals.
#2 0x0000006d0f0a4664 in fallout::combat_add_noncoms ()
at
/usr/ports/pobj/fallout1-ce-1.1.0/fallout1-ce-1.1.0/src/game/combat.cc:1917
obj = 0x6fadef26d0
index = 2
#3 fallout::combat_sequence ()
at
/usr/ports/pobj/fallout1-ce-1.1.0/fallout1-ce-1.1.0/src/game/combat.cc:2038
count = <optimized out>
index = <optimized out>
critter = <optimized out>
index = <optimized out>
critter = <optimized out>
#4 fallout::combat (attack=<optimized out>)
at
/usr/ports/pobj/fallout1-ce-1.1.0/fallout1-ce-1.1.0/src/game/combat.cc:2433
v6 = <optimized out>
v3 = <optimized out>
#5 0x0000006d0f116704 in fallout::scripts_check_state ()
at
/usr/ports/pobj/fallout1-ce-1.1.0/fallout1-ce-1.1.0/src/game/scripts.cc:780
ctx = <optimized out>
#6 0x0000006d0f0f048e in fallout::main_game_loop ()
at /usr/ports/pobj/fallout1-ce-1.1.0/fallout1-ce-1.1.0/src/game/main.cc:328
keyCode = <optimized out>
cursorWasHidden = <optimized out>
#7 0x0000006d0f0efd78 in fallout::gnw_main (argc=<optimized out>,
argv=<optimized out>)
at /usr/ports/pobj/fallout1-ce-1.1.0/fallout1-ce-1.1.0/src/game/main.cc:129
mainMenuRc = 1
language_filter = 0
done = <optimized out>
#8 0x0000006d0f08de5b in _start ()
