On Wed, 28 Jan 2026, Stuart Henderson wrote:
> The comments, many just different links to the same commit, are a bit
> confusing. Of the various URLs, probably including any more than
> https://bugzilla.redhat.com/show_bug.cgi?id=2319133 and
> https://developer.intra2net.com/git/?p=libftdi;a=commit;h=ff7707e3ffadc09af420b26370b9e097a5b2bc8b
> is too much. But often in ports for git commits we just include
> the header from the patch, e.g. for this I'd use
>
> ----
> From ff7707e3ffadc09af420b26370b9e097a5b2bc8b Mon Sep 17 00:00:00 2001
> From: William S Fulton <[email protected]>
> Date: Fri, 18 Oct 2024 09:38:20 +0200
> Subject: [PATCH 1/1] python: update for SWIG 4.3
>
> SWIG 4.3 comes with an API change to the SWIG_Python_AppendOutput()
> function, so switch to the recommended SWIG_AppendOutput() instead.
> Because the new function is a macro in fact also switch to the {..}
> delimiters as the code needs to be preprocessed. The change is
> compatible with the previous SWIG releases 4.2 and 4.1 at least.
>
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2319133
> Related: https://github.com/swig/swig/pull/2907
> ----
>
> (apart from anything else, this keeps providing useful info if the
> upstream git browser interface breaks).
>
> With some tidying or other of that, ok
>
That's great, thanks!
I'll definitely do that, and take the advice for future commits.
Stu
