from the changelog, I think we could do with multi-arch tests

I can do aarch64 (M2) and i386 in a bit


On 2026/09/25 15:38, Bjorn Ketelaars wrote:
> Diff below update xxhash to 0.8.4, which is a maintenance release.
> Changes: https://github.com/Cyan4973/xxHash/releases/tag/v0.8.4.
> 
> 'make test' passes all tests. Build tested most of the consumers without
> any issues. net/rsync will need a REVISION bump as xxhash is used there
> as a header-only library.
> 
> Comments / OK?
> 
> 
> diff --git Makefile Makefile
> index ba143e9d057..4c896402123 100644
> --- Makefile
> +++ Makefile
> @@ -3,9 +3,8 @@ COMMENT =     extremely fast non-cryptographic hash algorithm
>  # bump rsync on updates; used as a header-only library there
>  GH_ACCOUNT = Cyan4973
>  GH_PROJECT = xxHash
> -GH_TAGNAME = v0.8.3
> +GH_TAGNAME = v0.8.4
>  PKGNAME =    ${DISTNAME:L}
> -REVISION =   0
>  
>  SHARED_LIBS =        xxhash 1.0      # 0.8.3
>  
> diff --git distinfo distinfo
> index fac9cbe402f..697b93b8127 100644
> --- distinfo
> +++ distinfo
> @@ -1,2 +1,2 @@
> -SHA256 (xxHash-0.8.3.tar.gz) = quYI3+ghPf0F2QmldxjvgvMHIsOSNEWD0/OQUMfymoA=
> -SIZE (xxHash-0.8.3.tar.gz) = 1147630
> +SHA256 (xxHash-0.8.4.tar.gz) = VzgnCTXnw9OKebOt98lpJWbOeJWiX2feQ61Sq1BKzTI=
> +SIZE (xxHash-0.8.4.tar.gz) = 1167538
> diff --git patches/patch-Makefile patches/patch-Makefile
> index 607ac9be20c..7c81a1af2f2 100644
> --- patches/patch-Makefile
> +++ patches/patch-Makefile
> @@ -3,12 +3,12 @@ Don't create symbolic links pointing to the shared lib.
>  Index: Makefile
>  --- Makefile.orig
>  +++ Makefile
> -@@ -625,8 +625,6 @@ install_libxxhash: libxxhash
> +@@ -681,8 +681,6 @@ install_libxxhash: libxxhash
>       @echo Installing libxxhash
> -     $(Q)$(MAKE_DIR) $(DESTDIR)$(LIBDIR)
> -     $(Q)$(INSTALL_PROGRAM) $(LIBXXH) $(DESTDIR)$(LIBDIR)
> --    $(Q)ln -sf $(LIBXXH) $(DESTDIR)$(LIBDIR)/libxxhash.$(SHARED_EXT_MAJOR)
> --    $(Q)ln -sf $(LIBXXH) $(DESTDIR)$(LIBDIR)/libxxhash.$(SHARED_EXT)
> +     $(MAKE_DIR) $(DESTDIR)$(LIBDIR)
> +     $(INSTALL_PROGRAM) $(LIBXXH) $(DESTDIR)$(LIBDIR)
> +-    ln -sf $(LIBXXH) $(DESTDIR)$(LIBDIR)/libxxhash.$(SHARED_EXT_MAJOR)
> +-    ln -sf libxxhash.$(SHARED_EXT_MAJOR) 
> $(DESTDIR)$(LIBDIR)/libxxhash.$(SHARED_EXT)
>   
>   install_libxxhash.includes:
> -     $(Q)$(INSTALL) -d -m 755 $(DESTDIR)$(INCLUDEDIR)   # includes
> +     $(INSTALL) -d -m 755 $(DESTDIR)$(INCLUDEDIR)   # includes
> diff --git patches/patch-xxhash_h patches/patch-xxhash_h
> index 0c5e0d1410c..ee7b182772d 100644
> --- patches/patch-xxhash_h
> +++ patches/patch-xxhash_h
> @@ -1,7 +1,7 @@
>  Index: xxhash.h
>  --- xxhash.h.orig
>  +++ xxhash.h
> -@@ -2297,8 +2297,11 @@ XXH3_128bits_reset_withSecretandSeed(XXH_NOESCAPE XXH3
> +@@ -2296,8 +2296,11 @@ XXH3_128bits_reset_withSecretandSeed(XXH_NOESCAPE XXH3
>      /* prefer __packed__ structures (method 1) for GCC
>       * < ARMv7 with unaligned access (e.g. Raspbian armhf) still uses byte 
> shifting, so we use memcpy
>       * which for some reason does unaligned loads. */
> 

Reply via email to