On 2026/10/09 13:18, Lydia Sobot wrote:
> If you managed to fix those failing tests that's great, however actually
> based on some cursory research for instance on Void Linux they just disable
> tests because "some tests fail", so I think that it might be ok to import
> even with failing tests
Generally we only disable tests which error out and prevent other tests
from running, or they're hugely noisy or take a lot of time, otherwise
ports should not disable tests just because they fail.
I think the 2 failing tests here are _probably_ not all that important
and most likely relate to differences between OS.
=================================== FAILURES ===================================
_
PollPollerSocketEventsTestCase.test_which_events_are_set_after_local_shuts_rdwr
_
tests/unit/select_connection_ioloop_tests.py:1040: in
test_which_events_are_set_after_local_shuts_rdwr
self.which_events_are_set_with_varying_eventmasks(
tests/unit/select_connection_ioloop_tests.py:834: in
which_events_are_set_with_varying_eventmasks
ioloop.start()
pika/adapters/select_connection.py:583: in start
self._poller.start()
pika/adapters/select_connection.py:845: in start
self.poll()
pika/adapters/select_connection.py:1259: in poll
self._dispatch_fd_events(fd_event_map)
pika/adapters/select_connection.py:947: in _dispatch_fd_events
handler(fileno, events)
tests/unit/select_connection_ioloop_tests.py:819: in handle_socket_events
self.assertTrue(
E AssertionError: 0 is not true : watching=12: Out.Err.; indicated=16: Hup.
----------------------------- Captured stderr call -----------------------------
[PollPoller] @ Local shut RDWR: watching=13: In.Out.Err.; indicated=17:
In.Hup.; sockerr=0
[PollPoller] @ Local shut RDWR: watching=5: In.Out.; indicated=17: In.Hup.;
sockerr=0
[PollPoller] @ Local shut RDWR: watching=1: In.; indicated=17: In.Hup.;
sockerr=0
[PollPoller] @ Local shut RDWR: watching=12: Out.Err.; indicated=16: Hup.;
sockerr=0
_
PollPollerSocketEventsTestCase.test_which_events_are_set_when_failed_to_connect
_
tests/unit/select_connection_ioloop_tests.py:866: in
test_which_events_are_set_when_failed_to_connect
self.which_events_are_set_with_varying_eventmasks(
tests/unit/select_connection_ioloop_tests.py:834: in
which_events_are_set_with_varying_eventmasks
ioloop.start()
pika/adapters/select_connection.py:583: in start
self._poller.start()
pika/adapters/select_connection.py:845: in start
self.poll()
pika/adapters/select_connection.py:1259: in poll
self._dispatch_fd_events(fd_event_map)
pika/adapters/select_connection.py:947: in _dispatch_fd_events
handler(fileno, events)
tests/unit/select_connection_ioloop_tests.py:819: in handle_socket_events
self.assertTrue(
E AssertionError: 0 is not true : watching=12: Out.Err.; indicated=16: Hup.
----------------------------- Captured stderr call -----------------------------
[PollPoller] @ Failed to connect: watching=13: In.Out.Err.; indicated=17:
In.Hup.; sockerr=61 (Connection refused)
[PollPoller] @ Failed to connect: watching=5: In.Out.; indicated=17: In.Hup.;
sockerr=0
[PollPoller] @ Failed to connect: watching=1: In.; indicated=17: In.Hup.;
sockerr=0
[PollPoller] @ Failed to connect: watching=12: Out.Err.; indicated=16: Hup.;
sockerr=0
=========================== short test summary info ============================
FAILED
tests/unit/select_connection_ioloop_tests.py::PollPollerSocketEventsTestCase::test_which_events_are_set_after_l
ocal_shuts_rdwr
FAILED
tests/unit/select_connection_ioloop_tests.py::PollPollerSocketEventsTestCase::test_which_events_are_set_when_fa
iled_to_connect
============ 2 failed, 1143 passed, 59 skipped in 78.54s (0:01:18) =============
