On 2026-10-12, Stuart Henderson wrote: > On 2026-10-12 11:15, Joerg Jung wrote: > > > On 2026-11-12, Lucas de Sena <[email protected]> wrote: > > > Minor, style changes: > > > - lowercase $COMMENT > > > > While porters handbook recommend lowercase, > > to me Gopher is a proper noun (protocol name) > > +1
Makes sense. Am reverting back. Ok with replacing variable substitution with $V? On 2026-10-12, Stuart Henderson wrote: > > On 2026-11-12, Lucas de Sena <[email protected]> wrote: > > New installed files (post-install target): > > - Install examples for CGI and haproxy in > > /usr/local/share/examples/geomyidae. > > - Remove /usr/local/share/doc/geomyidae/README > > (it's only a 3-line-long file pointing to the manual geomyidae(8)) > > those make sense Keeping them. On 2026-10-12 11:15, Joerg Jung wrote: > On 2026-11-12, Lucas de Sena <[email protected]> wrote: > > Breaking changes: > > - Install the daemon into /usr/local/sbin rather than /usr/local/bin > > Why? Because daemons should be installed in sbin/. Other packages already do that. For example, mail/dovecot and www/nginx install their daemons at sbin/. On 2026-10-12, Stuart Henderson wrote: > On 2026-10-12 11:15, Joerg Jung wrote: > > > On 2026-11-12, Lucas de Sena <[email protected]> wrote: > > > - Remove "-l /var/log/geomyidae.log", for the log file is not managed by > > > newsyslog(8) and can grow up fast. > > > > This will log to stdout, which is IMHO not wanted. > > One can just easily add the missing rotation to either newsyslog or using > > any other rotation tool, if needed. > > I think so too, this is no different to web server logging etc Ok, I will revert back to the original geomyidae_flags. Although geomyidae does not log to stdout when -l is not given. My issue with it is that specifying a logfile requires creating a dummy empty log file at /usr/local/share/examples/geomyidae/log and add a @sample file at PLIST with the proper owner and mode. Kinda hacky. What about -c to run on chroot, tho? For me it is a good default. On 2026-10-12, Stuart Henderson wrote: > On 2026-11-12, Lucas de Sena <[email protected]> wrote: > > +share/examples/geomyidae/index.gph > > @mode 755 > > -@owner root > > +@owner _geomyidae > > @group daemon > > @sample /var/gopher/ > > -@mode > > -@owner > > -@group > > -share/examples/geomyidae/ > > -share/examples/geomyidae/index.gph > > @sample /var/gopher/index.gph > > having this directory and writable by the daemon seems suboptimal Fixed. Ok? diff /usr/ports/net/geomyidae path + /usr/ports/net/geomyidae commit - 8ded1a37c994a7a1aae562386ce4effb505e58f2 blob - 31e8b0c2274465a6bfe41d9c14da3fdc16bfe49c file + Makefile --- Makefile +++ Makefile @@ -1,9 +1,8 @@ COMMENT = Gopher protocol daemon -DISTNAME = geomyidae-v0.51 -PKGNAME = ${DISTNAME:S/-v/-/} -REVISION = 0 - +V = 0.99 +DISTNAME = geomyidae-v$V +PKGNAME = geomyidae-$V CATEGORIES = net HOMEPAGE = http://git.r-36.net/scm/geomyidae @@ -18,19 +17,23 @@ WANTLIB = c tls SITES = ftp://bitreich.org/releases/geomyidae/ -MAKE_FLAGS = CC="${CC}" CFLAGS="${CFLAGS} -Wall" \ +MAKE_FLAGS = BINDIR="${PREFIX}/sbin" \ MANDIR="${PREFIX}/man/man8" -MAKE_ENV = LDFLAGS="${LDFLAGS}" NO_TEST = Yes post-install: ${INSTALL_DATA_DIR} ${PREFIX}/share/doc/geomyidae ${INSTALL_DATA_DIR} ${PREFIX}/share/examples/geomyidae - cd ${WRKSRC} && ${INSTALL_DATA} CGI.md README \ - ${PREFIX}/share/doc/geomyidae - cd ${WRKSRC} && ${INSTALL_DATA} index.gph \ - ${PREFIX}/share/examples/geomyidae + ${INSTALL_DATA_DIR} ${PREFIX}/share/examples/geomyidae/cgi-examples + ${INSTALL_DATA_DIR} ${PREFIX}/share/examples/geomyidae/haproxy touch ${PREFIX}/share/examples/geomyidae/log + ${INSTALL_DATA} ${WRKSRC}/CGI.md ${PREFIX}/share/doc/geomyidae + ${INSTALL_DATA} ${WRKSRC}/index.gph \ + ${PREFIX}/share/examples/geomyidae + ${INSTALL_DATA} ${WRKSRC}/cgi-examples/* \ + ${PREFIX}/share/examples/geomyidae/cgi-examples + ${INSTALL_DATA} ${WRKSRC}/haproxy/* \ + ${PREFIX}/share/examples/geomyidae/haproxy .include <bsd.port.mk> commit - 8ded1a37c994a7a1aae562386ce4effb505e58f2 blob - 8257add4f14e9a369c4698b0dad08dccc2482eeb file + distinfo --- distinfo +++ distinfo @@ -1,2 +1,2 @@ -SHA256 (geomyidae-v0.51.tar.gz) = z65VWzcw4FYRTyAi7Gi83dnQWTpIZbNMcdrKlJqdiow= -SIZE (geomyidae-v0.51.tar.gz) = 33384 +SHA256 (geomyidae-v0.99.tar.gz) = QnAUqvyi+b14kIjqnreY6adFl62glRiuX9QiVamR6zw= +SIZE (geomyidae-v0.99.tar.gz) = 40436 commit - 8ded1a37c994a7a1aae562386ce4effb505e58f2 blob - 8d0ecd4b05303b3f190e32afab0cf40a389f9eda file + pkg/PLIST --- pkg/PLIST +++ pkg/PLIST @@ -1,11 +1,19 @@ @newgroup _geomyidae:754 @newuser _geomyidae:754:_geomyidae::Geomyidae Gopher Daemon:/nonexistent:/sbin/nologin @rcscript ${RCDIR}/geomyidae -@bin bin/geomyidae @man man/man8/geomyidae.8 +@bin sbin/geomyidae share/doc/geomyidae/ share/doc/geomyidae/CGI.md -share/doc/geomyidae/README +share/examples/geomyidae/ +share/examples/geomyidae/cgi-examples/ +share/examples/geomyidae/cgi-examples/dirlisting.dcgi +share/examples/geomyidae/cgi-examples/proxy.cgi +share/examples/geomyidae/cgi-examples/rest.dcgi +share/examples/geomyidae/cgi-examples/umnlisting.dcgi +share/examples/geomyidae/cgi-examples/vhosting.cgi +share/examples/geomyidae/haproxy/ +share/examples/geomyidae/haproxy/gopher-haproxy.cfg @mode 755 @owner root @group daemon @@ -13,7 +21,6 @@ share/doc/geomyidae/README @mode @owner @group -share/examples/geomyidae/ share/examples/geomyidae/index.gph @sample /var/gopher/index.gph share/examples/geomyidae/log commit - 8ded1a37c994a7a1aae562386ce4effb505e58f2 blob - 190f00e07714e33421c2900395db6cca695a999f file + pkg/geomyidae.rc --- pkg/geomyidae.rc +++ pkg/geomyidae.rc @@ -1,10 +1,10 @@ #!/bin/ksh -daemon="${TRUEPREFIX}/bin/geomyidae" -daemon_flags="-l /var/log/geomyidae.log -u _geomyidae -g _geomyidae" +daemon="${TRUEPREFIX}/sbin/geomyidae" +daemon_flags="-c -l /var/log/geomyidae.log -u _geomyidae -g _geomyidae" . /etc/rc.d/rc.subr -pexp="${daemon} .*" +rc_reload=NO rc_cmd $1
