Hi,
I think the issue was mostly my mail client (ThunderBird) settings, not
with the Claude helped patch.
Sorry about that one, set to plain text now and will add the patch as
attachment (like I do for FreeBSD too).
The patch works in our CI
https://github.com/annejan/qtpass-bsd-port-test/actions/runs/40343162180/job/121642970420
and in my VM.
x11/qt6/qtsvg is a shared lib only and not a plugin
It ships the plugins too, per its own PLIST
(https://github.com/openbsd/ports/blob/master/x11/qt6/qtsvg/pkg/PLIST):
@so lib/qt6/plugins/iconengines/libqsvgicon.so
@so lib/qt6/plugins/imageformats/libqsvg.so
QtPass bundles 15 SVG icons in its resources as fallbacks for theme
icons, for example `QIcon::fromTheme("edit-copy",
QIcon(":/icons/edit-copy.svg"))` and `QIcon::fromTheme("qrcode",
QIcon(":/icons/qrcode.svg"))`.
Qt renders those through the `libqsvgicon.so` icon engine. QtPass does
not link libQt6Svg (so nothing in WANTLIB, and port-lib-depends-check
stays clean),
which is why it is a RUN_DEPENDS: without it, every icon the desktop
theme does not provide (e.g. "qrcode", which most themes lack) shows up
blank.
Changes in from 1.8.2 to 1.8.4
- 1.8.4: a copied password carries the KDE password hint on OpenBSD and
FreeBSD too (was Linux-only), so Klipper, CopyQ and cliphist keep it out
of their history.
- 1.8.4: started from a terminal, QtPass no longer freezes when git or
ssh asks for credentials; child processes start without a controlling
terminal (Qt 6.7 or newer, which the ports tree has).
- 1.8.4: the desktop entry sets `StartupWMClass`.
- 1.8.3: a failed save no longer loses what was typed.
Changelog: https://github.com/IJHack/QtPass/blob/v1.8.4/CHANGELOG.md
Sorry about the inconvenience . . still trying to get a hold of this
regular releasing job ;-)
Anne Jan
On 10/26/26 19:42, Rafael Sadowski wrote:
On Mon Oct 26, 2026 at 07:12:56PM +0100, Anne Jan Brouwer wrote:
Hi,
updated diff for security/qtpass, superseding the 1.8.2 one. Upstream
released 1.8.3 on 2026-10-06 and 1.8.4 on 2026-10-26; the port stays on
Qt6, and nothing else in it changes.
Since 1.8.2:
- A copied password now carries the KDE password hint on OpenBSD and
FreeBSD too (it was Linux-only), so Klipper, CopyQ and cliphist keep
it out of their history.
- Started from a terminal, QtPass no longer freezes when git or ssh
asks for credentials: child processes start without a controlling
terminal (needs Qt 6.7 or newer, which the ports tree has).
- A failed save no longer loses what was typed (1.8.3).
- The desktop entry sets StartupWMClass.
Port changes against the 1.8.2 diff: GH_TAGNAME v1.8.4 and distinfo.
Against the port's current state (1.7.0) it is the same diff as before
otherwise: Qt6, the desktop file, icons and metainfo in PLIST, and the
matching RUN_DEPENDS.
Tested on OpenBSD 7.9 amd64 with the 7.9 ports tree and security/qtpass
from -current: portcheck, makesum, build, fake, update-plist reproduces
the PLIST, port-lib-depends-check, package, pkg_add.
CI:
https://github.com/annejan/qtpass-freebsd-port-test/actions/runs/40343162180
Changelog: https://github.com/IJHack/QtPass/blob/v1.8.4/CHANGELOG.md
The diff was prepared with AI assistance (Claude Code) and reviewed by
me.
It's a malformed patch. Was this also generated using Claude?
I hope that is not a problem,
Anne Jan Brouwer (QtPass upstream)
diff --git a/security/qtpass/Makefile b/security/qtpass/Makefile
index 34a2de4a..16bd352c 100644
--- a/security/qtpass/Makefile
+++ b/security/qtpass/Makefile
@@ -2,7 +2,7 @@ COMMENT= multi-platform GUI for password-store
GH_ACCOUNT= IJHack
GH_PROJECT= QtPass
-GH_TAGNAME= v1.7.0
+GH_TAGNAME= v1.8.4
PKGNAME= ${DISTNAME:L}
CATEGORIES= security x11
@@ -14,16 +14,19 @@ MAINTAINER= Stefan Hagen <[email protected]>
# GPLv3+
PERMIT_PACKAGE= Yes
-WANTLIB+= ${COMPILER_LIBCXX} GL Qt5Core Qt5Gui Qt5Network Qt5Widgets
+WANTLIB+= ${COMPILER_LIBCXX} GL Qt6Core Qt6Gui Qt6Network Qt6Widgets
WANTLIB+= c m
MODULES= devel/qmake \
- x11/qt5
+ x11/qt6
-RUN_DEPENDS= devel/git \
+RUN_DEPENDS= devel/desktop-file-utils \
+ devel/git \
security/gnupg>=2.2.23p1 \
security/password-store \
- security/pwgen
+ security/pwgen \
+ x11/gtk+4,-guic \
+ x11/qt6/qtsvg
Why? I don't think so. Perhaps because Claude spotted an SVG file in the
PLIST? x11/qt6/qtsvg is a shared lib only and not a plugin nor a bin
util.
NO_TEST= Yes
diff --git a/security/qtpass/distinfo b/security/qtpass/distinfo
index 36d3863b..a719f096 100644
--- a/security/qtpass/distinfo
+++ b/security/qtpass/distinfo
@@ -1,2 +1,2 @@
-SHA256 (QtPass-1.7.0.tar.gz) = Fte/ARFKfxHC42G0bhUGP0GaJ77/VKlphbcG2nVnA8M=
-SIZE (QtPass-1.7.0.tar.gz) = 1167619
+SHA256 (QtPass-1.8.4.tar.gz) = UjaDFUYr5paONCHq9OTgT6PyvzZlLok3Kky16iipASE=
+SIZE (QtPass-1.8.4.tar.gz) = 1755558
diff --git a/security/qtpass/pkg/PLIST b/security/qtpass/pkg/PLIST
index da179ffc..3cd6f5f6 100644
--- a/security/qtpass/pkg/PLIST
+++ b/security/qtpass/pkg/PLIST
@@ -1 +1,8 @@
@bin bin/qtpass
+share/applications/qtpass.desktop
+share/icons/hicolor/512x512/apps/qtpass-icon.png
+share/icons/hicolor/scalable/apps/qtpass-icon.svg
+share/metainfo/
+share/metainfo/org.qtpass.QtPass.metainfo.xml
+@tag update-desktop-database
+@tag gtk-update-icon-cache %D/share/icons/hicolor
I would suggest the following patch. Stefan, please commit if OK for
you.
Index: Makefile
===================================================================
RCS file: /cvs/ports/security/qtpass/Makefile,v
diff -u -p -r1.5 Makefile
--- Makefile 7 Jul 2026 06:22:28 -0000 1.5
+++ Makefile 26 Oct 2026 18:36:42 -0000
@@ -1,8 +1,7 @@
COMMENT= multi-platform GUI for password-store
-
GH_ACCOUNT= IJHack
GH_PROJECT= QtPass
-GH_TAGNAME= v1.7.0
+GH_TAGNAME= v1.8.4
PKGNAME= ${DISTNAME:L}
CATEGORIES= security x11
@@ -14,11 +13,11 @@ MAINTAINER= Stefan Hagen <sh+ports@codev
# GPLv3+
PERMIT_PACKAGE= Yes
-WANTLIB+= ${COMPILER_LIBCXX} GL Qt5Core Qt5Gui Qt5Network Qt5Widgets
-WANTLIB+= c m
+WANTLIB += ${COMPILER_LIBCXX} GL Qt6Core Qt6Gui Qt6Network Qt6Widgets
+WANTLIB += c m
MODULES= devel/qmake \
- x11/qt5
+ x11/qt6
RUN_DEPENDS= devel/git \
security/gnupg>=2.2.23p1 \
Index: distinfo
===================================================================
RCS file: /cvs/ports/security/qtpass/distinfo,v
diff -u -p -r1.3 distinfo
--- distinfo 7 Jul 2026 06:22:28 -0000 1.3
+++ distinfo 26 Oct 2026 18:36:42 -0000
@@ -1,2 +1,2 @@
-SHA256 (QtPass-1.7.0.tar.gz) = Fte/ARFKfxHC42G0bhUGP0GaJ77/VKlphbcG2nVnA8M=
-SIZE (QtPass-1.7.0.tar.gz) = 1167619
+SHA256 (QtPass-1.8.4.tar.gz) = UjaDFUYr5paONCHq9OTgT6PyvzZlLok3Kky16iipASE=
+SIZE (QtPass-1.8.4.tar.gz) = 1755558
Index: pkg/PLIST
===================================================================
RCS file: /cvs/ports/security/qtpass/pkg/PLIST,v
diff -u -p -r1.2 PLIST
--- pkg/PLIST 11 Mar 2022 19:53:59 -0000 1.2
+++ pkg/PLIST 26 Oct 2026 18:36:42 -0000
@@ -1 +1,15 @@
@bin bin/qtpass
+share/applications/
+share/applications/qtpass.desktop
+share/icons/
+share/icons/hicolor/
+share/icons/hicolor/512x512/
+share/icons/hicolor/512x512/apps/
+share/icons/hicolor/512x512/apps/qtpass-icon.png
+share/icons/hicolor/scalable/
+share/icons/hicolor/scalable/apps/
+share/icons/hicolor/scalable/apps/qtpass-icon.svg
+share/metainfo/
+share/metainfo/org.qtpass.QtPass.metainfo.xml
+@tag update-desktop-database
+@tag gtk-update-icon-cache %D/share/icons/hicolor
Index: Makefile
===================================================================
--- Makefile.orig
+++ Makefile
@@ -2,7 +2,7 @@ COMMENT= multi-platform GUI for password
GH_ACCOUNT= IJHack
GH_PROJECT= QtPass
-GH_TAGNAME= v1.7.0
+GH_TAGNAME= v1.8.4
PKGNAME= ${DISTNAME:L}
CATEGORIES= security x11
@@ -14,16 +14,17 @@ MAINTAINER= Stefan Hagen <sh+ports@codev
# GPLv3+
PERMIT_PACKAGE= Yes
-WANTLIB+= ${COMPILER_LIBCXX} GL Qt5Core Qt5Gui Qt5Network Qt5Widgets
-WANTLIB+= c m
+WANTLIB += ${COMPILER_LIBCXX} GL Qt6Core Qt6Gui Qt6Network Qt6Widgets
+WANTLIB += c m
MODULES= devel/qmake \
- x11/qt5
+ x11/qt6
RUN_DEPENDS= devel/git \
security/gnupg>=2.2.23p1 \
security/password-store \
- security/pwgen
+ security/pwgen \
+ x11/qt6/qtsvg
NO_TEST= Yes
Index: distinfo
===================================================================
--- distinfo.orig
+++ distinfo
@@ -1,2 +1,2 @@
-SHA256 (QtPass-1.7.0.tar.gz) = Fte/ARFKfxHC42G0bhUGP0GaJ77/VKlphbcG2nVnA8M=
-SIZE (QtPass-1.7.0.tar.gz) = 1167619
+SHA256 (QtPass-1.8.4.tar.gz) = UjaDFUYr5paONCHq9OTgT6PyvzZlLok3Kky16iipASE=
+SIZE (QtPass-1.8.4.tar.gz) = 1755558
Index: pkg/PLIST
===================================================================
--- pkg/PLIST.orig
+++ pkg/PLIST
@@ -1 +1,15 @@
@bin bin/qtpass
+share/applications/
+share/applications/qtpass.desktop
+share/icons/
+share/icons/hicolor/
+share/icons/hicolor/512x512/
+share/icons/hicolor/512x512/apps/
+share/icons/hicolor/512x512/apps/qtpass-icon.png
+share/icons/hicolor/scalable/
+share/icons/hicolor/scalable/apps/
+share/icons/hicolor/scalable/apps/qtpass-icon.svg
+share/metainfo/
+share/metainfo/org.qtpass.QtPass.metainfo.xml
+@tag update-desktop-database
+@tag gtk-update-icon-cache %D/share/icons/hicolor
