Lucas de Sena writes:
> PrBoomX is a DOOM source port forked from PrBoom+, that adds support for
> modern MBF21-compatible WADs, while keeping a codebase and interface
> close to the original PrBoom+.
>
> It is supposed to replace the unmaintained games/prboom-plus (whose
> development ceased in 2023, although we have an older version ported)
> and games/prboom (whose development ceased in 2008). The removal of
> both packages have already been proposed in another mail to ports@.
>
> It conflicts with games/prboom-plus because of the path where manuals
> are installed. I will send a patch upstream for that.
Personally, I would prefer that the directory and PKGNAME be lowercased.
This is the case for most ports in tree, even when the binary has
uppercase letters.
CFLAGS += -I${X11BASE}/include is not ideal, because if someone builds
with 'make CFLAGS=...' the option gets lost. Upstream should fix this
properly by doing the right cmake magic for it to pick up the include
headers from pkg-config. But in the meantime, you can add this to
CONFIGURE_ARGS: -DCMAKE_C_FLAGS="${CFLAGS} -I${X11BASE}/include"
As with all ports that use GL, 3D graphics, etc., I strongly recommend
enabling debug packages. If a crash occurs inside a graphics driver,
it will be difficult for a developer to reproduce the crash without the
exact same graphics hardware, so we want to make it as easy as possible
for the user to provide a full backtrace. So, please set DEBUG_PACKAGES =
${BUILD_PACKAGES}.
Otherwise, it looks good to me.