On Sat, Nov 14, 2026 at 11:18:14AM -0500, Brad Smith wrote:
> On 2026-11-14 4:15 a.m., Volker Schlecht wrote:
> > Node builds against textproc/simdutf in ports - maybe better to patch
> > there if
> > needed and perhaps webkitgtk4 can use it as well?
>
> Its still building the embedded copy. Its already fixed there.
So digging further. Node does, the copy of V8 does not.
This has been fixed with V8 and backported to newer Node. Backported
here.
Index: Makefile
===================================================================
RCS file: /cvs/ports/lang/node/Makefile,v
retrieving revision 1.178
diff -u -p -u -p -r1.178 Makefile
--- Makefile 11 Nov 2026 21:26:55 -0000 1.178
+++ Makefile 14 Nov 2026 17:53:50 -0000
@@ -13,6 +13,7 @@ DIST_TUPLE = codeberg qbit node-pledge
WRKDIST = ${WRKDIR}/${DISTNAME}
DISTNAME = node-${NODE_VERSION}
PKGNAME = ${DISTNAME:S/v//g}
+REVISION = 0
EPOCH = 0
CATEGORIES = lang devel
Index: patches/patch-deps_ada_ada_gyp
===================================================================
RCS file: patches/patch-deps_ada_ada_gyp
diff -N patches/patch-deps_ada_ada_gyp
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-deps_ada_ada_gyp 14 Nov 2026 17:53:50 -0000
@@ -0,0 +1,29 @@
+Do not use the bundled simdutf when built with --shared-simdutf.
+From upstream f3ae4554feb2d043cdc3d24898f6173add1fcac8 and V8 a0607c5006b8.
+
+Index: deps/ada/ada.gyp
+--- deps/ada/ada.gyp.orig
++++ deps/ada/ada.gyp
+@@ -8,7 +8,6 @@
+ 'type': 'static_library',
+ 'include_dirs': [
+ '.',
+- '<(DEPTH)/deps/v8/third_party/simdutf',
+ ],
+ 'direct_dependent_settings': {
+ 'include_dirs': ['.'],
+@@ -16,8 +15,12 @@
+ 'defines': [
+ 'ADA_USE_SIMDUTF=1',
+ ],
+- 'dependencies': [
+- '../../tools/v8_gypfiles/v8.gyp:simdutf',
++ 'conditions': [
++ ['node_shared_simdutf=="false"', {
++ 'dependencies': [
++ '../../tools/v8_gypfiles/v8.gyp:simdutf',
++ ],
++ }],
+ ],
+ 'sources': [ '<@(ada_sources)' ]
+ },
Index: patches/patch-deps_merve_merve_gyp
===================================================================
RCS file: patches/patch-deps_merve_merve_gyp
diff -N patches/patch-deps_merve_merve_gyp
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-deps_merve_merve_gyp 14 Nov 2026 17:53:50 -0000
@@ -0,0 +1,23 @@
+Do not use the bundled simdutf when built with --shared-simdutf.
+From upstream f3ae4554feb2d043cdc3d24898f6173add1fcac8 and V8 a0607c5006b8.
+
+Index: deps/merve/merve.gyp
+--- deps/merve/merve.gyp.orig
++++ deps/merve/merve.gyp
+@@ -8,13 +8,15 @@
+ 'type': 'static_library',
+ 'include_dirs': [
+ '.',
+- '../v8/third_party/simdutf',
+ ],
+ 'direct_dependent_settings': {
+ 'include_dirs': ['.'],
+ },
+ 'sources': [ '<@(merve_sources)' ],
+ 'conditions': [
++ ['node_shared_simdutf=="false"', {
++ 'include_dirs': ['../v8/third_party/simdutf'],
++ }],
+ ['OS=="win"', {
+ 'msvs_settings': {
+ 'VCCLCompilerTool': {
Index: patches/patch-deps_v8_src_builtins_builtins-typed-array_cc
===================================================================
RCS file: patches/patch-deps_v8_src_builtins_builtins-typed-array_cc
diff -N patches/patch-deps_v8_src_builtins_builtins-typed-array_cc
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-deps_v8_src_builtins_builtins-typed-array_cc 14 Nov 2026
17:53:50 -0000
@@ -0,0 +1,15 @@
+Do not use the bundled simdutf when built with --shared-simdutf.
+From upstream f3ae4554feb2d043cdc3d24898f6173add1fcac8 and V8 a0607c5006b8.
+
+Index: deps/v8/src/builtins/builtins-typed-array.cc
+--- deps/v8/src/builtins/builtins-typed-array.cc.orig
++++ deps/v8/src/builtins/builtins-typed-array.cc
+@@ -12,7 +12,7 @@
+ #include "src/objects/js-array-buffer-inl.h"
+ #include "src/objects/objects-inl.h"
+ #include "src/objects/simd.h"
+-#include "third_party/simdutf/simdutf.h"
++#include "simdutf.h"
+
+ namespace v8 {
+ namespace internal {
Index: patches/patch-deps_v8_src_objects_string_h
===================================================================
RCS file: patches/patch-deps_v8_src_objects_string_h
diff -N patches/patch-deps_v8_src_objects_string_h
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-deps_v8_src_objects_string_h 14 Nov 2026 17:53:50 -0000
@@ -0,0 +1,15 @@
+Do not use the bundled simdutf when built with --shared-simdutf.
+From upstream f3ae4554feb2d043cdc3d24898f6173add1fcac8 and V8 a0607c5006b8.
+
+Index: deps/v8/src/objects/string.h
+--- deps/v8/src/objects/string.h.orig
++++ deps/v8/src/objects/string.h
+@@ -21,7 +21,7 @@
+ #include "src/objects/tagged.h"
+ #include "src/sandbox/external-pointer.h"
+ #include "src/strings/unicode-decoder.h"
+-#include "third_party/simdutf/simdutf.h"
++#include "simdutf.h"
+
+ // Has to be the last include (doesn't have include guards):
+ #include "src/objects/object-macros.h"
Index: patches/patch-deps_v8_src_strings_unicode-inl_h
===================================================================
RCS file: patches/patch-deps_v8_src_strings_unicode-inl_h
diff -N patches/patch-deps_v8_src_strings_unicode-inl_h
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-deps_v8_src_strings_unicode-inl_h 14 Nov 2026 17:53:50
-0000
@@ -0,0 +1,15 @@
+Do not use the bundled simdutf when built with --shared-simdutf.
+From upstream f3ae4554feb2d043cdc3d24898f6173add1fcac8 and V8 a0607c5006b8.
+
+Index: deps/v8/src/strings/unicode-inl.h
+--- deps/v8/src/strings/unicode-inl.h.orig
++++ deps/v8/src/strings/unicode-inl.h
+@@ -10,7 +10,7 @@
+
+ #include "src/base/logging.h"
+ #include "src/utils/utils.h"
+-#include "third_party/simdutf/simdutf.h"
++#include "simdutf.h"
+
+ namespace unibrow {
+
Index: patches/patch-tools_v8_gypfiles_v8_gyp
===================================================================
RCS file: /cvs/ports/lang/node/patches/patch-tools_v8_gypfiles_v8_gyp,v
retrieving revision 1.22
diff -u -p -u -p -r1.22 patch-tools_v8_gypfiles_v8_gyp
--- patches/patch-tools_v8_gypfiles_v8_gyp 4 Aug 2026 17:13:12 -0000
1.22
+++ patches/patch-tools_v8_gypfiles_v8_gyp 14 Nov 2026 17:53:50 -0000
@@ -1,7 +1,19 @@
Index: tools/v8_gypfiles/v8.gyp
--- tools/v8_gypfiles/v8.gyp.orig
+++ tools/v8_gypfiles/v8.gyp
-@@ -736,7 +736,7 @@
+@@ -645,6 +645,11 @@
+ 'fp16',
+ 'abseil.gyp:abseil',
+ ],
++ 'conditions': [
++ ['node_shared_simdutf=="false"', {
++ 'dependencies': ['simdutf'],
++ }],
++ ],
+ 'direct_dependent_settings': {
+ 'sources': [
+ '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn"
"v8_header_set.\\"v8_internal_headers\\".*?sources = ")',
+@@ -736,7 +741,7 @@
}],
['v8_enable_webassembly==1', {
'conditions': [
@@ -10,7 +22,7 @@ Index: tools/v8_gypfiles/v8.gyp
'sources': [
'<(V8_ROOT)/src/trap-handler/handler-inside-posix.h',
],
-@@ -779,7 +779,7 @@
+@@ -779,7 +784,7 @@
}],
['v8_enable_webassembly==1', {
'conditions': [
@@ -19,7 +31,15 @@ Index: tools/v8_gypfiles/v8.gyp
'sources': [
'<(V8_ROOT)/src/trap-handler/handler-inside-posix.h',
],
-@@ -1156,7 +1156,7 @@
+@@ -1079,7 +1084,6 @@
+ 'v8_pch',
+ 'fp16',
+ 'highway',
+- 'simdutf',
+ 'abseil.gyp:abseil',
+ ],
+ 'includes': ['inspector.gypi'],
+@@ -1156,7 +1160,7 @@
}],
['v8_enable_webassembly==1', {
'conditions': [
@@ -28,7 +48,7 @@ Index: tools/v8_gypfiles/v8.gyp
'sources': [
'<(V8_ROOT)/src/trap-handler/handler-inside-posix.cc',
'<(V8_ROOT)/src/trap-handler/handler-outside-posix.cc',
-@@ -1184,7 +1184,7 @@
+@@ -1184,7 +1188,7 @@
'conditions': [
['v8_enable_webassembly==1', {
'conditions': [
@@ -37,7 +57,7 @@ Index: tools/v8_gypfiles/v8.gyp
'sources': [
'<(V8_ROOT)/src/trap-handler/handler-inside-posix.cc',
'<(V8_ROOT)/src/trap-handler/handler-outside-posix.cc',
-@@ -1232,7 +1232,7 @@
+@@ -1232,7 +1236,7 @@
'conditions': [
['v8_enable_webassembly==1', {
'conditions': [
@@ -46,7 +66,7 @@ Index: tools/v8_gypfiles/v8.gyp
'sources': [
'<(V8_ROOT)/src/trap-handler/handler-inside-posix.cc',
'<(V8_ROOT)/src/trap-handler/handler-outside-posix.cc',
-@@ -1327,7 +1327,7 @@
+@@ -1327,7 +1331,7 @@
# Platforms that don't have Compare-And-Swap (CAS) support need to
link atomic library
# to implement atomic memory access.
# Clang needs it for some atomic operations
(https://clang.llvm.org/docs/Toolchain.html#atomics-library).
@@ -55,3 +75,12 @@ Index: tools/v8_gypfiles/v8.gyp
'link_settings': {
'libraries': ['-latomic', ],
},
+@@ -2426,7 +2430,7 @@
+ 'target_name': 'simdutf',
+ 'type': 'static_library',
+ 'toolsets': ['host', 'target'],
+- 'direct_dependent_settings': {
++ 'all_dependent_settings': {
+ 'include_dirs': [
+ '<(V8_ROOT)/third_party/simdutf',
+ ],