Stuart Henderson writes:
> On 2026/11/16 15:53, Thomas Frohwein wrote:
> > On Mon, 16 Nov 2026 22:15:40 +0200
> > Timo Myyrä <[email protected]> wrote:
> > 
> > > +                       -DCMAKE_C_FLAGS="${CFLAGS}
> > > -I${X11BASE}/include" \
> > > +                       -DCMAKE_CXX_FLAGS="${CXXFLAGS} -I.
> > > -I${LOCALBASE}/include" 
> > > -CFLAGS +=              -I${X11BASE}/include
> > > -CXXFLAGS +=            -I. -I${LOCALBASE}/include
> > 
> > I'm not sure if this recommendation is really agreed upon. Many ports
> > set CFLAGS or CXXFLAGS like gzdoom has been doing. Modifications for
> > them are listed in Makefile.template, and bsd.port.mk(5) contains no
> > warning about them as in the email that led to this change.
> > 
> > Happy to hear others chime in, but modifying these flags has long been
> > a standard and easy way to fix these common issues with missing include
> > directories...
> > 
>
> There's no need to change those.

Overriding CFLAGS at the command line isn't common and isn't important
enough to, say, sweep the tree for.

But in a new port, given the choice between two lines overriding CFLAGS
that break 'make CFLAGS=...' and two only marginally more complicated
lines that don't, I see no reason not to favor the latter.

Reply via email to