Hi Devin-

On Mon, Jun 16, 2008 at 10:45:23AM -0700, Devin Smith wrote:
> Some questions I had:
>
> 1. I wasn't sure if PKGNAME should have the p0 appended or should it just
>    be ${DISTNAME}.

The pN suffix is the port patchlevel; if you're bumping the upstream
version, you don't need it. Since PKGNAME=DISTNAME by default, you
can just omit the PKGNAME= entirely.

> 2. When adding / deleting files to create a cvs diff should I be
>    using the cvsdo utility (http://viper.haque.net/~timeless/redbean/)?
>    It seemed easier to use then editing the CVS/Entries file manually.

In most cases, you should be able to simply 'cvs {add,remove}' the
relevant files.

[...]
> Index: patches/patch-rdpsnd_sun_c
> ===================================================================
> RCS file: patches/patch-rdpsnd_sun_c
> diff -N patches/patch-rdpsnd_sun_c
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ patches/patch-rdpsnd_sun_c        17 Jun 2008 23:57:36 -0000
> @@ -0,0 +1,40 @@
> +$OpenBSD$
> +
> +2 changes are here:
> +- Change all uint_t to unsigned int.  On Linux a uint_t is just a typedef
> +  to unsigned int.  We don't have a uint_t.
> +
> +- In sun_open rdesktop will also check that a device is in full duplex
> +  mode before opening the device successfully. I didn't add code to check
> +  if a device is in full duplex mode, I just removed the check.

We don't usually include comments in the patch files.

-- 

o--------------------------{ Will Maier }--------------------------o
| web:.......http://www.lfod.us/ | [EMAIL PROTECTED] |
*---------------------[ BSD: Live Free or Die ]--------------------*

Reply via email to