On Fri, Sep 05, 2008 at 12:38:15PM +0100, Stuart Henderson wrote:
> > COMMENT = Rockbox Utility
>
> this could be a bit more descriptive, maybe something like
> "tool to install Rockbox firmware on portable music players"
>
Too long
install rockbox firmware on ipod
(does it apply to other mp3 players ?)
> > WRKBUILD = ${WRKDIR}/rockbox-*/rbutil/rbutilqt
> > WRKDIST = ${WRKDIR}/rockbox-*/rbutil
NO WILDCARD in WRKBUILD and WRKDIST, this does *not* work, as soon as
you update the port, if anyone has got a wrkdir checked out, this will
*fail* in a momentous way.
Don't define WRKBUILD like that,
WRKBUILD = ${WRKDIST}/rbutilqt
is much better. Remember make variables are lazy, so the order does NOT matter.
> > NO_CHECKSUM = YES
>
> we can't put something in the tree which basically downloads what
> could be some totally random software and runs it on build machines
> without checking what it is. NO_CHECKSUM is for special cases e.g.
> where the source is not fetched from a MASTER_SITE, rather it's
> included right in the tree. (very uncommon).
Indeed. Forbidden!
> > # Need to know what to do to make this happen.
>
> fetch a copy and optionally repack (maybe without the whole
> rockbox firmware source tree), then either host it yourself,
> or ask here if someone can help with that.
>
> > CHECK_LIB_DEPENDS = YES
>
> oh, I didn't know you could do that, well spotted :) it's not
> something that would be normally set in a port's own Makefile though,
> rather something you could set in mk.conf, or on the make command
> line. (probably more useful on bulk build machines to identify
> problems; while you're working on a port, it's quicker to "make
> port-lib-depends-check" now we have that option).
This is documented in bsd.port.mk as User settings, minus the typo.
*Anything* documented as user settings only belongs in mk.conf.
If there was a simple automated way to check it does come from a Makefile,
this would error out.
