On Tue, Jan 12, 2010 at 09:35:36AM +0100, Landry Breuil wrote: > On Mon, Jan 11, 2010 at 11:17:14PM -0600, Abel Abraham Camarillo Ojeda wrote: > > Landry Breuil <lan...@rhaalovely.net> wrote: > > > > > On Tue, Jan 05, 2010 at 03:52:14PM -0600, Abel Abraham Camarillo Ojeda > > > wrote: > > > > Abel Abraham Camarillo Ojeda <acam...@the00z.org> wrote: > > > > > > > > > $ cat DESCR > > > > > Vimprobable is a WWW browser that behaves like the Vimperator plugin > > > > > available for Mozilla Firefox. It is based on the WebKit engine > > > > > (using GTK bindings). It is a fork of the currently abandoned > > > > > vimpression. > > > > > > > > > > This is vimprobable2 an alpha version. > > > > > $ > > > > > > > > > > Please test it and comment... or complain, or commit. > > > > > > > > > > -- > > > > > DISCLAIMER: http://goldmark.org/jeff/stupid-disclaimers/ > > > > > This message will self-destruct in 3 seconds. > > > > > > > > damn... forgot to attach the port. > > > > > > Some comments portswise, as everyone seems to want this in but noone > > > cares of the porting style : > > > - patch-config_h makes no sense to me. Maybe you wanted to comment the > > > line below ? Is there a keybinding bringing to a search engine listed > > > here ? (didn't find in manpage) > > > - soup-2.4 doesn't belong in LIB_DEPENDS as it's already in webkit > > > depends. > > > - PKGNAME=${DISTNAME} is not needed > > > - since you manage MASTER_SITES (you do?), you can make a .tar.gz and > > > remove > > > EXTRACT_SUFX ? > > > - in patch-Makefile, PREFIX ?= /usr/local/ is.. nicer than PREFIX = > > > ${DESTDIR}/usr/local (at least to me), as PREFIX is correctly set in > > > environment during fake stage. > > > - make port-lib-depends-check complains (at least here) : > > > WANTLIB: iconv.6 from libiconv-1.13 (/usr/local/bin/vimprobable2) > > > Extra: dbus-1.7 > > > Extra: dbus-glib-1.4 > > > Extra: sqlite3.13 > > > WANTLIB += iconv > > > > > > Was it just a copy/pasto of Midori's makefile WANTLIB ? > > > > > > Landry > > > > Is it ok to change the default search page to google? > > > > at this time the default search engine can only be changed at compile time. > > > > Or would it be better if I just add google has another option to :open ? > > Yeah, much better imho. We try to avoid changing default behaviour, > and i'm pretty sure if you default to google the usual google-haters > will scream around.
Yeah we would! > > > maybe I can put an option 'g' to do: > > > > :open g string1 string2 > > > > and search in google.com. > > That's a non-intrusive improvement. > > Landry >
