On Sun, Jul 18, 2010 at 07:34:54PM +0200, Sebastian Reitenbach wrote:
> Hi,
>
> appended three new tcl/tk related ports. Since the last submission a
> couple of weeks ago, more or less completely reworked.
>
> graphics/tkimg:
> This package enhances Tk, adding support for many
> other Image formats: BMP, XBM, XPM, GIF (with
> transparency, but without LZW), PNG, JPEG, TIFF.
patch-Makefile_in looks wrong to me. what's that fucking up with fake
dirs ? And what rm -r ${DESTDIR}/Img is doing in post-install ? that's a
two-step install target ?
patch-XXX_configure should contain LIBfoo_VERSION (+ added to
SUBST_VARS) to be cleaner... oh well. whatever. If there's only one
SHLIB_VERSION.. forget about it :)
-x-includes should use ${X11BASE}
replace that ugly sed+mv in post-install by a perl -pi construct
why not trying to fix coccinella to work with png package instead of
just disabling it ?
> net/tcludp:
> This package provides support for using UDP through Tcl.
> The package provides a new channel type and attempts to
> permit the use of packet oriented UDP over stream oriented
> Tcl channels.
looks good
> misc/memchan:
> Memchan is an extension to Tcl implementing memory channels,
> i.e. channels storing the data placed into them in memory,
> not on disk.
ok for me. send string.h patches upstream..
on a general note:
does enabling threads in those ports forces you to have a threaded tcl
install ? ie does it actually work with a default non threaded tcl ?
If not, shouldn't it depend on the threaded flavor of tcl port ? All
this really sounds like the threaded-perl-python-ruby-fuckup...
Landry
