On Sat, Nov 06, 2010 at 08:02:45PM +0100, Matthias Kilian wrote:
> Enable -qt4 for powerpc, only keep it disabled for arm (because qt4
> currently doesn't build there).
>
> ok?
No.
This is not how things should work.
You do not set a pseudo flavor based on arch.
You don't need to.
The NOT_FOR_ARCHS-qt4 = arm
is enough to both have correct MULTI_PACKAGES for dump-vars, *and* to
have the build system do the right thing.
Look at bsd.port.mk internals: it uses _MULTI_PACKAGES wherever it makes
sense, and _MULTI_PACKAGES is deduced from MULTI_PACKAGES by amputating
what does not build.
Let me summarize:
if you have a multi-packages port, it will often be along the lines of:
MULTI_PACKAGES = -main -foo
CONFIGURE_ARGS += --enable-foo
if foo does not build on some architecture, what's needed is simply:
MULTI_PACKAGES = -main -foo
NOT_FOR_ARCHS-arm = -foo
.include <bsd.own.mk>
.if ${MACHINE_ARCH} != "arm"
CONFIGURE_ARGS += --enable-foo
.endif
e.g., the infrastructure stuff happens "magically" as soon as you set
NOT_FOR_ARCHS-<arch>
you only need to take care manually of the configury/building part,
since there can be no magic there.
