On Wed, Mar 16, 2011 at 06:54:03PM +0100, Landry Breuil wrote: > On Wed, Mar 16, 2011 at 08:20:02PM +0300, Igor Zinovik wrote: > > On Mar 16, Landry Breuil wrote: > > > Port reads and installs good. You might want to fix the english though.. > > > > > > 'Mojolicious is a MVC web framework that supports the following features' > > > > > > ok for me if anyone wants to import it.. > > > > I added missing article. Here is tarball with updated pkg/DESCR. > > > > BTW what we have to do with www/p5-Mojo? > > Looking at the files, it looks like it's an update and it got renamed in > the meantime... so keep the name p5-Mojo and update it here. > > Landry
Igor, I hope I read your diff right. Here is my opinion about this.. Looking at your last diff you didn't change the PKGNAME. If you provide new PKGNAME for this port I think it would be better if you import this port to new location (www/p5-Mojolicious) and add @pkgpath/@conflict markers against old port. If you however want to import it as Landry advised in old pkgpath (www/p5-Mojo) I think it would be better to keep old PKGNAME (no @conflict markers needed then). You can also stay with your current approach -- old pkgpath (www/p5-Mojo) and new PKGNAME (p5-Mojolicious), but then if I'm not mistaken, you need/should add @conflict marker to PLIST against old PKGNAME. Feedback from other porters welcome. I would go with new pkgpath and new pkgname, and maybe would add quirks. Also, I would go with CPAN_AUTHOR instead of MASTER_SITE in the Makefile. -- best regards q#
