On Thu, Apr 28, 2011 at 2:39 PM, Landry Breuil <lan...@rhaalovely.net> wrote: >> 3. Should I make a separate RenderTexture port instead, and patch >> OpenCSG to depend on that? > > That would be better, if more stuff want to depend on it later. If not.. > your call.
I think I'll leave it bundled for the time being then. It's just one .cpp and one .h file, and RenderTexture upstream doesn't even bother distributing a real Makefile with it. >> 4. libopencsg.so depends on symbols from libGLEW.so, but upstream >> doesn't actually link it against libGLEW.so, so I only added >> graphics/glew to BUILD_DEPENDS rather than LIB_DEPENDS. Is this >> correct, or should I patch it to link against libGLEW.so and/or >> add to LIB_DEPENDS instead? > > It all depends if a binary linked with it fails at runtime or not. I'm > not sure if there are previous similar things with libGL*.so. > Explicitely linking with it might be safer. Will do.