2011/6/14 Federico Schwindt <fg...@lodoss.net>:
> new version attached:
>
> - remove setuptools and pip from the package
> - add pip as dependency
would you explain why force use system's pip but not the pip come with
virtualenv ?
> - add REGRESS_DEPENDS and remove NO_REGRESS. while the port has no
> regressions (in the distributed tarball at least) it does no break and
> the missing files might be added in the future so why not.
Agree. I made this change too.
But I think these lines should be added to Makefile:
+REGRESS_DEPENDS = devel/py-mock \
+ devel/py-nose
+
+do-regress: fake
+ @cd ${WRKSRC} && \
+ ${MAKE_ENV} ${MODPY_BIN} setup.py test
> - trim DESCR
Agree.
> - lowercase comment
Agree.
wen
>
> f.-
>
> On Tue, Jun 14, 2011 at 10:25 AM, Federico Schwindt <fg...@lodoss.net> wrote:
>> this doesn't look correct to me. what is this?
>>
>> lib/python${MODPY_VERSION}/site-packages/virtualenv_support/distribute-0.6.16.tar.gz
>> lib/python${MODPY_VERSION}/site-packages/virtualenv_support/pip-1.0.1.tar.gz
>> lib/python${MODPY_VERSION}/site-packages/virtualenv_support/setuptools-0.6c11-py${MODPY_VERSION}.egg
>>
>> this should only install virtualenv.py and virtualenv and depend on
>> py-pip. everything under virtualenv_support should not be installed.
>>
>> f.-
>>
>> On Tue, Jun 14, 2011 at 6:41 AM, Remi Pointel <remi.poin...@xiri.fr> wrote:
>>> On Mon, 13 Jun 2011 23:02:03 +0200
>>> Landry Breuil <lan...@rhaalovely.net> wrote:
>>>> On Sun, Jun 12, 2011 at 10:49:28PM +0200, viq wrote:
>>>> > On Mon, Apr 11, 2011 at 06:21:29PM +0800, wen heping wrote:
>>>> > > 2011/4/11 Piotr Sikora <piotr.sik...@frickle.com>:
>>>> > > > Hi,
>>>> > > >
>>>> > > >> Comments ?
>>>> > > >
>>>> > > > It's very similar to the one I've got in my ports tree (attached),
>>>> > > > but you've got two things wrong:
>>>> > > > 1) Python ports need MODPY_EGG_VERSION,
>>>> > > > 2) you should add spaces around "=" in the Makefile variables.
>>>> > > >
>>>> > >
>>>> > > I attached revised tar file here, thank you.
>>>> > >
>>>> > > wen
>>>> > >
>>>> > >
>>>> > >
>>>> > > > Best regards,
>>>> > > > Piotr Sikora < piotr.sik...@frickle.com >
>>>> > > >
>>>> >
>>>> > This sounds interesting for playing with things there are no ports for,
>>>> > did anyone look at this?
>>>>
>>>> Reads good to me, someone interested in python (remi ? :) should import it.
>>>
>>> Hi,
>>>
>>> format of MAINTAINER was not correct, and PLIST was not regenerated with
>>> MODPY_EGG_VERSION.
>>> Also, I seen a new minor version (1.6.1) has been released.
>>>
>>> Attached is the tarball with these modifications.
>>>
>>> Wen, are you ok with my tarball ? Does it works fine for you ?
>>>
>>> Thanks,
>>>
>>> Remi.
>>>
>>
>
